l.org
[mailto:platform-driver-x86-ow...@vger.kernel.org] On Behalf Of Darren Hart
Sent: Friday, December 11, 2015 7:02 AM
To: Andy Shevchenko
Cc: Zha, Qipeng ; platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V9 2/2] platform:x86: add Intel P-Unit mailbox IPC driver
On Thu, Dec 10, 2015 at 01:23:05PM
>> +Andriy who originally raised the concern over the ACPI resource
>> assumptions in
>> the previous version. Andriy, this resource allocation looks to be a
>> substantial improvement to me. Do you have any further concerns?
>So, regarding to the second patch
>1. In excerpts like following
>if
> On Mon, 2015-10-26 at 08:51 +0000, Zha, Qipeng wrote:
> > > So the ASL you provided was not what the Linux kernel is seeing,
> > > correct?
> >
> > > Can you please provide a DSDT disassembly from the running Linux
> > > system please, such as:
&
>So the ASL you provided was not what the Linux kernel is seeing, correct?
>Can you please provide a DSDT disassembly from the running Linux system
>please, such as:
># cp /sys/firmware/acpi/tables/DSDT DSDT.dat # iasl -d DSDT.dat
>Then find this device in DSDT.dsl and paste it here please.
S
Darren, Andriy:
Thanks for your kind review, try to make clear as below.
+Gavin, Our BIOS developer.
On Thu, Oct 22, 2015 at 01:01:32AM +, Zha, Qipeng wrote:
> >>Qipeng, can you comment on my understanding of the DSDT and the driver?
> >> > // Memory32Fixed (
s entry will change to 4B, not the default 0x1000.
This is real strange implementation for us, as before mentioned, BIOS implement
like this to make it compatible for wos driver.
On Wed, Oct 14, 2015 at 10:16:06PM -0700, Darren Hart wrote:
> On Sat, Oct 10, 2015 at 03:07:53AM +, Zha, Qipeng
>Everything is quite okay, except this BAR thingy.
>Can you provide a DSDT excerpt for the device to see what is there?
>I can't find such device (by ACPI id) in the tables of the accessible hardware
>in our lab.
Please check below acpi device definition from BIOS.
Punit device is created in p
>>> + ipcdev.base[BIOS_MAILBOX] = addr;
>>> + addr += MAILBOX_REGISTER_SPACE;
>>> + ipcdev.base[GTDRIVER_MAILBOX] = addr;
>>> + addr += MAILBOX_REGISTER_SPACE;
>>> + ipcdev.base[ISPDRIVER_MAILBOX] = addr;
>>Looks akward, does the platform have the several resources for different
>>purp
>> >> +/* Some modules are dependent on this, so init earlier */
>> >> +fs_initcall(intel_punit_ipc_init);
>>
>> >So, what exactly requires this?
>> Those drivers which need to use this Punit APIs in its Probe when do module
>> init.
>As you know, cross driver calls is something we work to avoi
>> +struct intel_punit_ipc_controller {
>> +struct platform_device *pdev;
>Usually we keep pointer to struct device. Any specific reason to hold
>platform_device here?
Because intel_punit_get_bars() need to use platform_device pointer to get
resources.
>> +
>> +static int intel_punit_ipc_ch
On Tue, Aug 18, 2015 at 04:50:56PM +0100, Matt Fleming wrote:
> On Mon, 2015-08-10 at 16:04 +0100, Shevchenko, Andriy wrote:
> >
> > Matt, by the way intel_pmc_ipc.c module creates iTCO device (LPC bus).
> > Does it look correct?
>
> Yeah, it looks OK to me. Note there are changes queued up in Le
Fei
Registers access is one of ipc functions and other ipc commands can't be
wrapped as register access,
So I don't think we can only keep regmap apis.
Best wishes
Qipeng
-Original Message-
From: Yang, Fei
Sent: Thursday, April 23, 2015 12:30 PM
To: Zha, Qipeng; platform-
other driver need to access pmic registers) can use
generic regmap_read/_write Directly.
Best wishes
Qipeng
-Original Message-
From: One Thousand Gnomes [mailto:gno...@lxorguk.ukuu.org.uk]
Sent: Wednesday, April 22, 2015 6:37 PM
To: Zha, Qipeng
Cc: "platform-driver-x86@vger.
Thousand Gnomes [mailto:gno...@lxorguk.ukuu.org.uk]
Sent: Tuesday, April 21, 2015 7:59 PM
To: Zha, Qipeng
Cc: platform-driver-x86@vger.kernel.org; dvh...@infradead.org; Yang, Fei;
Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi
Subject: Re: [PATCH] platform:x86: add Intel Broxton PMC IPC driver
On Tue, 21
Behalf Of One Thousand
Gnomes
Sent: Tuesday, April 21, 2015 1:26 AM
To: Zha, Qipeng
Cc: platform-driver-x86@vger.kernel.org; dvh...@infradead.org; Yang, Fei;
Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi
Subject: Re: [PATCH] platform:x86: add Intel Broxton PMC IPC driver
On Tue, 21 Apr 2015 07:04:29
Hi Dear
Could you confirm the git tree is below to maintain platform x86 driver ? If
not , could you tell me which one Thanks.
It report non reachable when I clone it.
git clone
https://git.kernel.org/pub/scm/linux/kernel/git/mjg59/platform-drivers-x86.git
Best wishes
Qipeng
-Original Me
16 matches
Mail list logo
