Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-12-01 Thread Michał Kępień
> Module parameters are to be avoided wherever possible, especially for things > like this which set precedent and don't scale well. If we cannot detect which > machines use the EC and which only use WMI, then we can fall back to checking > DMI for specific models. > > Per the above, and Pali's

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-30 Thread Darren Hart
On Thu, Nov 26, 2015 at 03:18:32PM +0100, Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > is generated. As there is no flawless way to determine whether a given > machine is

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-30 Thread Michał Kępień
> The best would be if embedded controller could be configured to send > events via i8042 bus... Yes, but if I correctly understand Mario's message back from July [1], V131's EC simply does not support generating scancodes at all. > I'm starting to thing that blacklist or whitelist of machines

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-30 Thread Darren Hart
On Mon, Nov 30, 2015 at 03:54:58PM +0100, Michał Kępień wrote: > > The best would be if embedded controller could be configured to send > > events via i8042 bus... > > Yes, but if I correctly understand Mario's message back from July [1], > V131's EC simply does not support generating scancodes

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-30 Thread Michał Kępień
Hi Pali, Thanks again for your efforts. > $ sudo /usr/bin/input-events 4 > /dev/input/event4 > bustype : BUS_I8042 > vendor : 0x1 > product : 0x1 > version : 43841 > name: "AT Translated Set 2 keyboard" > phys: "isa0060/serio0/input0" > bits ev : EV_SYN

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-30 Thread Pali Rohár
On Monday 30 November 2015 15:14:00 Michał Kępień wrote: > Hi Pali, > > Thanks again for your efforts. > > > $ sudo /usr/bin/input-events 4 > > /dev/input/event4 > > bustype : BUS_I8042 > > vendor : 0x1 > > product : 0x1 > > version : 43841 > > name: "AT Translated Set 2

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-29 Thread Pali Rohár
On Thursday 26 November 2015 15:55:56 Michał Kępień wrote: > > > /* Shortcut and audio panel keys */ > > > > > > - { KE_IGNORE, 0xe025, { KEY_RESERVED } }, > > > + { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > I'm trying to figure out if

[PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-26 Thread Michał Kępień
On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 is generated. As there is no flawless way to determine whether a given machine is capable of simulating a keypress when this hotkey is pressed, a new

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-26 Thread Pali Rohár
On Thursday 26 November 2015 15:18:32 Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > is generated. As there is no flawless way to determine whether a given > machine is

Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing

2015-11-26 Thread Michał Kępień
Hi Pali, > Can you wait just a little bit? Till end of month two Dell kernel devs > are on vacation, so after that they maybe answer to question about new > hotkey format/support in kernel. Absolutely, after all this issue is already several months old (or even years, depending on how you