[PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-26 Thread Joe Perches
vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses no_printk which produces no logging output but always evaluates arguments. Change the macro to surround the no_printk call with do { if (0) no_printk(...); } while (0) to avoid the unnecessary argument evaluations. $ size drivers/

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-26 Thread Henrique de Moraes Holschuh
On Wed, Aug 26, 2015, at 15:13, Joe Perches wrote: > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > no_printk which produces no logging output but always > evaluates arguments. > > Change the macro to surround the no_printk call with > do { if (0) no_printk(...); } while (0) >

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-26 Thread Joe Perches
On Wed, 2015-08-26 at 15:27 -0300, Henrique de Moraes Holschuh wrote: > On Wed, Aug 26, 2015, at 15:13, Joe Perches wrote: > > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > > no_printk which produces no logging output but always > > evaluates arguments. > > > > Change the macro to s

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-27 Thread Henrique de Moraes Holschuh
On Wed, 26 Aug 2015, Joe Perches wrote: > On Wed, 2015-08-26 at 15:27 -0300, Henrique de Moraes Holschuh wrote: > > On Wed, Aug 26, 2015, at 15:13, Joe Perches wrote: > > > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > > > no_printk which produces no logging output but always > > > e

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-27 Thread Henrique de Moraes Holschuh
On Wed, 26 Aug 2015, Joe Perches wrote: > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > no_printk which produces no logging output but always > evaluates arguments. > > Change the macro to surround the no_printk call with > do { if (0) no_printk(...); } while (0) > to avoid th

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

2015-08-28 Thread Darren Hart
On Thu, Aug 27, 2015 at 02:33:06PM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 26 Aug 2015, Joe Perches wrote: > > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > > no_printk which produces no logging output but always > > evaluates arguments. > > > > Change the macro to surro