Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2015-04-24 Thread Alex Hung
I encountered a Dell Latitude machine whose wireless hotkey will not work with dell-rbtn alone, and therefore I merged functions from dell-wireless and it worked quite well. I also tested it on 7 other Dell machines, and only Inspiron 7437 failed because of a firmware bug (see http://permalink.gma

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2015-01-05 Thread Alex Hung
When a key is pressed and released, KBC sends a pair of corresponding scancode - a make and a break. In normal case, a make code and a break code differ in one bit - break = make | BIT7. Therefore, a scancode with BIT7 set is a break. There are special cases such as super key that maps to "0xe0 0x5

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-29 Thread Pali Rohár
On Monday 29 December 2014 08:27:21 Alex Hung wrote: > On Fri, Dec 26, 2014 at 5:55 AM, Gabriele Mazzotta > > wrote: > > On Thursday 25 December 2014 21:11:05 Pali Rohár wrote: > >> I will try to recap all information which we have... > >> > >> *) We should not send wireless key press to userspa

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-28 Thread Alex Hung
On Fri, Dec 26, 2014 at 5:55 AM, Gabriele Mazzotta wrote: > On Thursday 25 December 2014 21:11:05 Pali Rohár wrote: >> I will try to recap all information which we have... >> >> *) We should not send wireless key press to userspace when BIOS >> already handles wireless state (and enable/disable wi

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-25 Thread Gabriele Mazzotta
On Thursday 25 December 2014 21:11:05 Pali Rohár wrote: > I will try to recap all information which we have... > > *) We should not send wireless key press to userspace when BIOS > already handles wireless state (and enable/disable wifi): > http://www.spinics.net/lists/platform-driver-x86/msg059

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-25 Thread Pali Rohár
I will try to recap all information which we have... *) We should not send wireless key press to userspace when BIOS already handles wireless state (and enable/disable wifi): http://www.spinics.net/lists/platform-driver-x86/msg05922.html *) some tested dell machines does not implement GRBT meth

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-24 Thread Alex Hung
I usually prefer to stick with formal document as everything else can be changed without reasons. I am not certain whether the keypress is defined in Dell's document, and I will confirm with Dell. If this keypress is well defined, it is a good idea to use it. On Wed, Dec 24, 2014 at 7:40 PM, Gab

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-24 Thread Gabriele Mazzotta
On Wednesday 24 December 2014 17:13:45 Alex Hung wrote: > I uploaded acpidump files [1] (except for XPS 13 which is not > available), and this should help clarify what has been tested. > > Does Inspirion 5721 does not have either DELLABCE or DELRBTN. It is > used for comparison. My apologies that

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-24 Thread Alex Hung
I uploaded acpidump files [1] (except for XPS 13 which is not available), and this should help clarify what has been tested. Does Inspirion 5721 does not have either DELLABCE or DELRBTN. It is used for comparison. My apologies that I did not point this out in previous email. When calling ARBT(1),

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-22 Thread Gabriele Mazzotta
On Monday 22 December 2014 15:27:57 Alex Hung wrote: > = Testing = > > I tested six Dell systems for two sets of patches for dell radio > button - two system with radio slider and four with radio hotkey. > There are also two systems with working ARBT method. > > == Basic Information == > Based OS

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-22 Thread Gabriele Mazzotta
On Monday 22 December 2014 15:27:57 Alex Hung wrote: > = Testing = > > I tested six Dell systems for two sets of patches for dell radio > button - two system with radio slider and four with radio hotkey. > There are also two systems with working ARBT method. > > == Basic Information == > Based OS

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-22 Thread Pali Rohár
Hello, thank you very much for testing. On Monday 22 December 2014 08:27:57 Alex Hung wrote: > = Testing = > > I tested six Dell systems for two sets of patches for dell > radio button - two system with radio slider and four with > radio hotkey. There are also two systems with working ARBT > meth

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-21 Thread Alex Hung
= Testing = I tested six Dell systems for two sets of patches for dell radio button - two system with radio slider and four with radio hotkey. There are also two systems with working ARBT method. == Basic Information == Based OS: Ubuntu 14.10 (kernel 3.16 [1]) and kernel 3.18 [2] Patches: 1. del

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Gabriele Mazzotta
On Friday 05 December 2014 22:23:25 Pali Rohár wrote: > On Friday 05 December 2014 22:12:42 Gabriele Mazzotta wrote: > > On Friday 05 December 2014 22:03:24 Pali Rohár wrote: > > > On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote: > > > > On Friday 05 December 2014 21:38:17 Pali Rohár wr

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Pali Rohár
On Friday 05 December 2014 22:12:42 Gabriele Mazzotta wrote: > On Friday 05 December 2014 22:03:24 Pali Rohár wrote: > > On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote: > > > On Friday 05 December 2014 21:38:17 Pali Rohár wrote: > > > > On Wednesday 03 December 2014 14:00:23 Darren Har

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Gabriele Mazzotta
On Friday 05 December 2014 22:03:24 Pali Rohár wrote: > On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote: > > On Friday 05 December 2014 21:38:17 Pali Rohár wrote: > > > On Wednesday 03 December 2014 14:00:23 Darren Hart wrote: > > > > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Pali Rohár
On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote: > On Friday 05 December 2014 21:38:17 Pali Rohár wrote: > > On Wednesday 03 December 2014 14:00:23 Darren Hart wrote: > > > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote: > > > > Darren, I think that if we do not solve proble

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Gabriele Mazzotta
On Friday 05 December 2014 21:38:17 Pali Rohár wrote: > On Wednesday 03 December 2014 14:00:23 Darren Hart wrote: > > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote: > > > Darren, I think that if we do not solve problem with > > > duplicate key events (in dell-wireless.c) we should > >

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-05 Thread Pali Rohár
On Wednesday 03 December 2014 14:00:23 Darren Hart wrote: > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote: > > Darren, I think that if we do not solve problem with > > duplicate key events (in dell-wireless.c) we should > > postpone these patches to later kernel version. It is > > bett

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-04 Thread Darren Hart
On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote: > > Darren, I think that if we do not solve problem with duplicate > key events (in dell-wireless.c) we should postpone these patches > to later kernel version. It is better to not have such regression > as it confuse software like Net

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-04 Thread Darren Hart
On Thu, Dec 04, 2014 at 04:16:25PM +0800, Alex Hung wrote: > HI Darren and Pali, > > It was great that we had a lot of discussion but it seems Dell BIOS > implementation varies from one series to another. Both work looks good > either one is fine with me. > > But I think I can do a little more: I

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-04 Thread Pali Rohár
On Thursday 04 December 2014 09:16:25 Alex Hung wrote: > HI Darren and Pali, > > It was great that we had a lot of discussion but it seems Dell > BIOS implementation varies from one series to another. Both > work looks good either one is fine with me. > Alex, am I right that your dell-wireless.c

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-04 Thread Alex Hung
HI Darren and Pali, It was great that we had a lot of discussion but it seems Dell BIOS implementation varies from one series to another. Both work looks good either one is fine with me. But I think I can do a little more: I am collecting a number of systems to try out these patches. This should

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-02 Thread Pali Rohár
On Wednesday 26 November 2014 00:05:28 Darren Hart wrote: > On Sun, Nov 23, 2014 at 04:09:18PM +0100, Pali Rohár wrote: > > This patch series add new acpi Dell Airplane Mode Switch > > driver (DELLABCE and DELRBTN acpi devices). It provides > > radio HW switch events (together with current state of

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-01 Thread Darren Hart
On Sun, Nov 23, 2014 at 04:09:18PM +0100, Pali Rohár wrote: > This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and > DELRBTN acpi devices). It provides radio HW switch events (together with > current > state of radio devices) and export them via rfkill interface. These eve

[PATCH 0/3] Dell Airplane Mode Switch driver

2014-11-23 Thread Pali Rohár
This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and DELRBTN acpi devices). It provides radio HW switch events (together with current state of radio devices) and export them via rfkill interface. These events are also used in dell-laptop driver instead i8042 filter hook fun