Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-25 Thread Corentin Chary
On Fri, Nov 25, 2011 at 8:18 PM, David Herrmann wrote: > On Thu, Nov 24, 2011 at 8:07 AM, Corentin Chary > wrote: >> Hi David,I refreshed the patches on the github repo, could you re-try >> them ?Thanks > > Works great. The error message doesn't appear anymore. The devices > still work as expecte

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-25 Thread David Herrmann
On Thu, Nov 24, 2011 at 8:07 AM, Corentin Chary wrote: > Hi David,I refreshed the patches on the github repo, could you re-try > them ?Thanks Works great. The error message doesn't appear anymore. The devices still work as expected. Tested-by: David Herrmann Thanks David > -- > Corentin Chary

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-23 Thread Corentin Chary
Hi David,I refreshed the patches on the github repo, could you re-try them ?Thanks -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-23 Thread Corentin Chary
On Wed, Nov 23, 2011 at 5:41 PM, David Herrmann wrote: > On Wed, Nov 23, 2011 at 7:35 AM, Corentin Chary > wrote: >> On Tue, Nov 22, 2011 at 11:23 PM, Greg KH wrote: >>> On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: Signed-off-by: Corentin Chary >>> >>> What happens on bo

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 7:35 AM, Corentin Chary wrote: > On Tue, Nov 22, 2011 at 11:23 PM, Greg KH wrote: >> On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: >>> Signed-off-by: Corentin Chary >> >> What happens on boxes that don't have this type of hardware?  Will the >> LED devic

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-22 Thread Corentin Chary
On Tue, Nov 22, 2011 at 11:23 PM, Greg KH wrote: > On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: >> Signed-off-by: Corentin Chary > > What happens on boxes that don't have this type of hardware?  Will the > LED device still show up, yet it will not work? > > You should be able t

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary What happens on boxes that don't have this type of hardware? Will the LED device still show up, yet it will not work? You should be able to trigger this off of the model type somehow, much like the v

[PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-22 Thread Corentin Chary
Signed-off-by: Corentin Chary --- drivers/platform/x86/Kconfig |2 + drivers/platform/x86/samsung-laptop.c | 136 + 2 files changed, 138 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 2f7a