Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

2011-02-08 Thread Guenter Roeck
On Tue, Feb 08, 2011 at 09:08:00AM -0500, Alan Cox wrote: On Tue, 8 Feb 2011 13:52:28 + Matthew Garrett mj...@srcf.ucam.org wrote: On Tue, Feb 08, 2011 at 10:45:35AM +, Alan Cox wrote: On Mon, 7 Feb 2011 19:58:43 + Matthew Garrett mj...@srcf.ucam.org wrote: hwmon

Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

2011-02-08 Thread Alan Cox
Ok, if the hardware has no mechanism for reporting the instantaneous draw then I can see it not working well in an hwmon sense. But I'd really prefer to see this look far more generic than it does - surely other hardware has similar functionality? I've not seen any - not anything

Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

2011-02-08 Thread Guenter Roeck
On Tue, Feb 08, 2011 at 10:56:29AM -0500, Matthew Garrett wrote: On Tue, Feb 08, 2011 at 07:49:16AM -0800, Guenter Roeck wrote: Seems to me there is some hair splitting going on here. Core element of hwmon drivers is that there are reported temperatures, voltages, current, power,

Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

2011-02-07 Thread Matthew Garrett
hwmon includes support for exposing the instantaneous current draw. hwmon includes support for triggering events if a parameter crosses a threshold. I still don't see why this isn't an hwmon driver, perhaps with a small platform driver for the more estoric bits of the setup. -- Matthew

[PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

2011-01-25 Thread Alan Cox
From: Durgadoss R durgados...@intel.com This patch enables over current detection on the Intel Medfield Platform. This driver provides sysfs interfaces to configure current thresholds. When the current being drawn on the platform exceeds the configured threshold, an interrupt is generated. This