[PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-20 Thread Andy Lutomirski
If DMI lists a hotkey that we don't recognize, log and ignore it instead of trying to map it to keycode 0. I haven't seen this happen, but it will help maintain the key map in the future and it will help avoid sending bogus events. This also improves the message that we log when we get an unknown

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-20 Thread Andy Lutomirski
On Fri, Nov 20, 2015 at 5:27 PM, Andy Lutomirski wrote: > If DMI lists a hotkey that we don't recognize, log and ignore it > instead of trying to map it to keycode 0. I haven't seen this happen, > but it will help maintain the key map in the future and it will help > avoid sending bogus events. >

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-23 Thread Pali Rohár
On Friday 20 November 2015 17:30:13 Andy Lutomirski wrote: > On Fri, Nov 20, 2015 at 5:27 PM, Andy Lutomirski wrote: > > If DMI lists a hotkey that we don't recognize, log and ignore it > > instead of trying to map it to keycode 0. I haven't seen this happen, > > but it will help maintain the key

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-23 Thread Darren Hart
On Mon, Nov 23, 2015 at 03:56:43PM +0100, Pali Rohár wrote: > On Friday 20 November 2015 17:30:13 Andy Lutomirski wrote: > > On Fri, Nov 20, 2015 at 5:27 PM, Andy Lutomirski wrote: > > > If DMI lists a hotkey that we don't recognize, log and ignore it > > > instead of trying to map it to keycode 0

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-23 Thread Andy Lutomirski
On Mon, Nov 23, 2015 at 10:47 AM, Darren Hart wrote: > On Mon, Nov 23, 2015 at 03:56:43PM +0100, Pali Rohár wrote: >> On Friday 20 November 2015 17:30:13 Andy Lutomirski wrote: >> > On Fri, Nov 20, 2015 at 5:27 PM, Andy Lutomirski wrote: >> > > If DMI lists a hotkey that we don't recognize, log a

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-23 Thread Pali Rohár
On Friday 20 November 2015 17:27:00 Andy Lutomirski wrote: > + if (keycode == KEY_RESERVED) { > + pr_info("firmware scancode %d maps to unrecognized > keycode %d\n", > + bios_entry->scancode, bios_entry->keycode); > +

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-30 Thread Darren Hart
On Mon, Nov 23, 2015 at 08:47:10PM +0100, Pali Rohár wrote: > On Friday 20 November 2015 17:27:00 Andy Lutomirski wrote: > > + if (keycode == KEY_RESERVED) { > > + pr_info("firmware scancode %d maps to unrecognized > > keycode %d\n", > > + bios

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

2015-11-30 Thread Andy Lutomirski
On Mon, Nov 30, 2015 at 10:27 AM, Darren Hart wrote: > On Mon, Nov 23, 2015 at 08:47:10PM +0100, Pali Rohár wrote: >> On Friday 20 November 2015 17:27:00 Andy Lutomirski wrote: >> > + if (keycode == KEY_RESERVED) { >> > + pr_info("firmware scancode %d maps to unrecogniz