Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Pali Rohár
On Tuesday 01 December 2015 20:51:34 Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > is generated. As there seems to be no ACPI method or SMI call to > determine without

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Pali Rohár
On Thursday 03 December 2015 17:16:06 Darren Hart wrote: > This looks fine to me, and if Pali will ack it, I'll move it from for-review > to > testing and Andy will need to update patch 14/14 to accomodate - unless you > guys > decide to include this in his. This patch is not enough for

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Andy Lutomirski
On Fri, Dec 4, 2015 at 4:55 AM, Michał Kępień wrote: >> > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant >> > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 >> > is generated. As there seems to be no ACPI method or SMI call to

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Michał Kępień
> > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -47,6 +47,38 @@ static int acpi_video; > > > > MODULE_ALIAS("wmi:"DELL_EVENT_GUID); > > > > +struct quirk_entry { > > + bool process_dell_instant_launch; > > +}; > > + > > +static struct quirk_entry

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Michał Kępień
> This patch is not enough for enabling 0xe025 key on that Vostro machine. > Some extra SMBIOS call is needed, without them ACPI will not send WMI > keypress event. Indeed. But have you read the last e-mail I wrote before submitting the original patch [1]? Brightness control on the V131 is

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-04 Thread Michał Kępień
> > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > > is generated. As there seems to be no ACPI method or SMI call to > > determine without possible side effects whether a given machine is > >

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-03 Thread Darren Hart
On Tue, Dec 01, 2015 at 08:51:34PM +0100, Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > is generated. As there seems to be no ACPI method or SMI call to > determine

[PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

2015-12-01 Thread Michał Kępień
On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 is generated. As there seems to be no ACPI method or SMI call to determine without possible side effects whether a given machine is capable of