Re: rpm5 package verification and md5sum of config files

2012-10-22 Thread Jeffrey Johnson
On Oct 22, 2012, at 9:56 AM, Jan Rękorajski wrote: > On Mon, 22 Oct 2012, Jeffrey Johnson wrote: > >> >> On Oct 22, 2012, at 6:44 AM, Jan Rękorajski wrote: >> >>> >>> Rebuilding ~8500 packages is not an option, unfortunately :( >>> >> >> Um … you managed to *build* ~8500 packages using a b

Re: rpm5 package verification and md5sum of config files

2012-10-22 Thread Jan Rękorajski
On Mon, 22 Oct 2012, Jeffrey Johnson wrote: > > On Oct 22, 2012, at 6:44 AM, Jan Rękorajski wrote: > > > > > Rebuilding ~8500 packages is not an option, unfortunately :( > > > > Um … you managed to *build* ~8500 packages using a buggy > rpmbuild in rpm-5.4.10. > > What makes *rebuilding* har

Re: rpm5 package verification and md5sum of config files

2012-10-22 Thread Jeffrey Johnson
On Oct 22, 2012, at 6:44 AM, Jan Rękorajski wrote: > > Rebuilding ~8500 packages is not an option, unfortunately :( > Um … you managed to *build* ~8500 packages using a buggy rpmbuild in rpm-5.4.10. What makes *rebuilding* harder than building? Note that not all 8500 packages are affected (o

Re: rpm5 package verification and md5sum of config files

2012-10-22 Thread Adam Osuchowski
Jan Rękorajski wrote: > Quick question, does passing '--nohmacs' option give the same effect as > your patch to lib/verify.c? In that case we could just make it default > and add '--hmacs' option. No. --nohmacs option disables checking hmac entirely even for truly modified files (with hmac verify

Re: rpm5 package verification and md5sum of config files

2012-10-22 Thread Jan Rękorajski
On Sun, 21 Oct 2012, Adam Osuchowski wrote: > Jan Rękorajski wrote: > > I'm afraid your patch doesn't work for me, I'm still getting bad md5 > > for config files: > > > > $ rpm -V wget > > ..5. c /etc/wgetrc > > > > Am I missing something? > > Ok, I made investigation one more time and pro

Re: rpm5 package verification and md5sum of config files

2012-10-21 Thread Jeffrey Johnson
On Oct 21, 2012, at 2:12 PM, Adam Osuchowski wrote: > > IMHO, first method is more elegant but is more difficult and it's not > worth it. Ripping out functionality is hardly less difficult. Yes: you need to rebuild packages affected with rpmbuild +PATCH. The symptom -- -Va false positives for

Re: rpm5 package verification and md5sum of config files

2012-10-21 Thread Adam Osuchowski
Jan Rękorajski wrote: > I'm afraid your patch doesn't work for me, I'm still getting bad md5 > for config files: > > $ rpm -V wget > ..5. c /etc/wgetrc > > Am I missing something? Ok, I made investigation one more time and probably know what happened. The patch I sent is against build/file

Re: rpm5 package verification and md5sum of config files

2012-10-16 Thread Adam Osuchowski
Jan Rękorajski wrote: > I'm afraid your patch doesn't work for me, I'm still getting bad md5 > for config files: > > $ rpm -V wget > ..5. c /etc/wgetrc > > Am I missing something? Hmmm, I don't know. Maybe I changed something else during debugging and forgot about it. Give me some time, I w

Re: rpm5 package verification and md5sum of config files

2012-10-16 Thread Jan Rękorajski
On Tue, 16 Oct 2012, Adam Osuchowski wrote: > Jan Rękorajski wrote: > > Adam, which bug is fixed by your 1-liner? > > The original one: rpm shows bad md5 digest of files marked as > `%verify(no md5)' (config files) although they are not modified. I'm afraid your patch doesn't work for me, I'm st

Re: rpm5 package verification and md5sum of config files

2012-10-16 Thread Jeffrey Johnson
On Oct 16, 2012, at 2:37 AM, Jan Rękorajski wrote: > > The confusion here is because Adam found a second bug during duscussion > here, so it happened to be two reports mixed, the one above > and the '--nofdigests' option breakage - if you add this > option then rpm5 reports _all_ files as havin

Re: rpm5 package verification and md5sum of config files

2012-10-16 Thread Jeffrey Johnson
On Oct 16, 2012, at 2:57 AM, Adam Osuchowski wrote: > > FYI, I don't claim that my 1-liner is the best solution for first case. > I only find it helps. Maybe there is more suitable one. Actually your 1-liner deletion *is* the best patch. (aside) I dimly remember having to debug this issue. Be

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Adam Osuchowski
Jan Rękorajski wrote: > Adam, which bug is fixed by your 1-liner? The original one: rpm shows bad md5 digest of files marked as `%verify(no md5)' (config files) although they are not modified. Second case (--nomd5 shows that all files are modified) was only a proof that there may be a general bug

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Jeffrey Johnson
On Oct 16, 2012, at 2:37 AM, Jan Rękorajski wrote: > > Adam, which bug is fixed by your 1-liner? > Eeek! I missed the patch. Apologies for being obnoxious: I haven't heard a bug report on this code in years (but PLD is always first to find my RPM flaws ;-). H … here is cvs annotate: 1.

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Jan Rękorajski
On Tue, 16 Oct 2012, Jeffrey Johnson wrote: > > On Oct 16, 2012, at 2:14 AM, Jan Rękorajski wrote: > > > As simple as possible: > > > > $ rpm -V wget > > ..5. c /etc/wgetrc > > > > - rpm reports /etc/wgetrc on disk has different digest than in package > > > > md5 of /etc/wgetrc in packa

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Jeffrey Johnson
On Oct 16, 2012, at 2:14 AM, Jan Rękorajski wrote: > As simple as possible: > > $ rpm -V wget > ..5. c /etc/wgetrc > > - rpm reports /etc/wgetrc on disk has different digest than in package > > md5 of /etc/wgetrc in package: > > $ rpm -qf --qf '%{FILEDIGESTS}\n' /etc/wgetrc > 0dbf720f5c

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Jan Rękorajski
As simple as possible: $ rpm -V wget ..5. c /etc/wgetrc - rpm reports /etc/wgetrc on disk has different digest than in package md5 of /etc/wgetrc in package: $ rpm -qf --qf '%{FILEDIGESTS}\n' /etc/wgetrc 0dbf720f5c9d29cbad8356f758a6a889 md5 of /etc/wgetrc on disk: $ md5sum /etc/wgetrc 0d

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Jeffrey Johnson
On Oct 15, 2012, at 6:47 PM, Adam Osuchowski wrote: > Jeffrey Johnson wrote: >> FYI: the --nomd5 option changed to --nofdigests like 4-5y ago. >> If there is still "legacy compatibility" for --nomd5, then its time >> to rip it out imho: I see no reason to maintain myriad >> confusing alternative

Re: rpm5 package verification and md5sum of config files

2012-10-15 Thread Adam Osuchowski
Jeffrey Johnson wrote: > FYI: the --nomd5 option changed to --nofdigests like 4-5y ago. > If there is still "legacy compatibility" for --nomd5, then its time > to rip it out imho: I see no reason to maintain myriad > confusing alternative invocations for changes made years ago. What's the differen

Re: rpm5 package verification and md5sum of config files

2012-10-14 Thread Jeffrey Johnson
On Oct 14, 2012, at 3:28 PM, Adam Osuchowski wrote: > Jeffrey Johnson wrote: >> The comparison is against the file on disk (and includes check of mtime) >> md5sum /etc/wgetrc >> (or whatever digest you are using: the '5' is mostly hysterical these days) > > Ok, I know that comparison is ag

Re: rpm5 package verification and md5sum of config files

2012-10-14 Thread Adam Osuchowski
Jeffrey Johnson wrote: > The comparison is against the file on disk (and includes check of mtime) > md5sum /etc/wgetrc > (or whatever digest you are using: the '5' is mostly hysterical these days) Ok, I know that comparison is against the file on disk but that's what it's all about. Why rpm

Re: rpm5 package verification and md5sum of config files

2012-10-14 Thread Jeffrey Johnson
On Oct 14, 2012, at 2:51 PM, Adam Osuchowski wrote: > Package verification by rpm-5.4.10-18 always shows config files as modified > (md5sum changed) even though they are not modified. > > For example: > > root@pld:~# rpm -q --qf '[%{filemd5s} %{filenames}\n]' systemd-units | grep > /etc/syste

rpm5 package verification and md5sum of config files

2012-10-14 Thread Adam Osuchowski
Package verification by rpm-5.4.10-18 always shows config files as modified (md5sum changed) even though they are not modified. For example: root@pld:~# rpm -q --qf '[%{filemd5s} %{filenames}\n]' systemd-units | grep /etc/systemd/system-preset/default.preset ; md5sum /etc/systemd/system-preset