Re: [Plplot-devel] More discussion of our adopted rebase workflow

2014-09-23 Thread Alan W. Irwin
On 2014-09-23 16:01-0700 David MacMahon wrote: > Just to nit pick: isn't this more of a pre-push check rather than client side enforcement? Nit picking aside, I agree that with rebase-only it easier to check for potential push problems on the client side *before* pushing. Hi David: Your comment

Re: [Plplot-devel] More discussion of our adopted rebase workflow

2014-09-23 Thread David MacMahon
Hi, Alan, On Sep 23, 2014, at 12:35 PM, Alan W. Irwin wrote: > On 2014-09-23 09:54-0700 David MacMahon wrote: > >> Emailing patches is tedious and error prone. > > I disagree. I have been applying user-generated patches to PLplot for > years without any patch-related errors. And I really like

[Plplot-devel] More discussion of our adopted rebase workflow

2014-09-23 Thread Alan W. Irwin
Hi David: I changed the subject line to something more appropriate. On 2014-09-23 09:54-0700 David MacMahon wrote: > Hi, Alan, > > On Sep 22, 2014, at 12:37 PM, Alan W. Irwin wrote: > >> You are much more experienced with git than me. However, I thought >> that rebasing a public branch was alwa

Re: [Plplot-devel] Exit calls and memory management

2014-09-23 Thread David MacMahon
Hi, Alan, On Sep 22, 2014, at 12:37 PM, Alan W. Irwin wrote: > You are much more experienced with git than me. However, I thought > that rebasing a public branch was always a bad idea for the reasons I > mentioned concerning disappearing commits. I am positive a number of > resources I read whe

Re: [Plplot-devel] Exit calls and memory management

2014-09-23 Thread Alan W. Irwin
On 2014-09-23 03:30-0700 phil rosenberg wrote: > @Hazen and Alan > I think an email went AWOL from Hazen somewhere, but from Alan's reply I > guess it probably said that we should not be rebasing public branches. I must > confess that I think almost everything I have read about rebasing says do

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread phil rosenberg
Hi Alan For this case the strings are hard coded somewhere in our code I think as the only thing that is passed is the driver dll name e.g. "ps" or "svg" etc. which are all plain ascii. I therefore don't think there is any interaction with user code for the input to LoadLibrary. This is why I si

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Alan W. Irwin
On 2014-09-23 10:36- Arjen Markus wrote: > Hi Phil, > I will definitely try these changes with Cygwin and MinGW. Pairs of functions for handling ASCII and UNICODE strings are ubiquitous under Windows and I do not expect trouble like Cygwin or MinGW not supporting the two flavours. Still, that

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Alan W. Irwin
On 2014-09-23 11:13+0100 Phil Rosenberg wrote: > Hi Alan I found the problem. On Windows LoadLibrary is a macro. If _UNICODE > is defined it is an alias for LoadLibraryW which requires a wide character > string in utf16 encoding. Otherwise it is an alias for LoadLibraryA which > requires a cha

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Arjen Markus
Hi Phil, I will definitely try these changes with Cygwin and MinGW. Pairs of functions for handling ASCII and UNICODE strings are ubiquitous under Windows and I do not expect trouble like Cygwin or MinGW not supporting the two flavours. Still, that needs to be checked. Glad you have been a

Re: [Plplot-devel] Exit calls and memory management

2014-09-23 Thread phil rosenberg
@Hazen and Alan I think an email went AWOL from Hazen somewhere, but from Alan's reply I guess it probably said that we should not be rebasing public branches. I must confess that I think almost everything I have read about rebasing says do not rebase a public branch. I'm certainly no expert, bu

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Phil Rosenberg
Cheers Arjen. I think I now have all needed directories in my path. Touch wood everything is working as it should. See my other email for details Phil -Original Message- From: "Arjen Markus" Sent: ‎23/‎09/‎2014 08:46 To: "Phil Rosenberg" Cc: "PLplot development list" Subject: RE: [Pl

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Phil Rosenberg
Hi Alan I found the problem. On Windows LoadLibrary is a macro. If _UNICODE is defined it is an alias for LoadLibraryW which requires a wide character string in utf16 encoding. Otherwise it is an alias for LoadLibraryA which requires a char string witch ascii encoding. This same method is used

Re: [Plplot-devel] tcl build problem

2014-09-23 Thread Arjen Markus
Hi Phil, I have seen the 0-sized driver info files too, but they were always caused by the test-driver-info program not being able to load. By extending the path with the dll-directory that the DLLs will put into _before_ starting the build that problem was resolved. However, I do not know ho