On 2017-12-12 17:36-0700 Orion Poplawski wrote:
Sorry I wasn't clear. The test was failing because of the compile error. With the patch the test returns "found" and the build is normal/successful.
Hi Orion: Thanks for that key clarification. Based on that good news for gcc NaN awareness with no special options on i686 hardware, I have made a slightly more conservative upstream change then your patch (just in case there is any non-gcc i*86 cases where the -mieee-fp compiler option builds and is still required for the NaN awareness test to still work). See <https://sourceforge.net/p/plplot/plplot/ci/5c628406e9a1c941dbe34d3db056f985e1ec8b08> for details. For your pure gcc case, your patch and the git master upstream version, i.e., [...] if(CMAKE_SYSTEM_PROCESSOR MATCHES "i[0-9]86" AND NOT CMAKE_C_COMPILER MATCHES "gcc") set(NAN_CFLAGS "${NAN_CFLAGS} -mieee-fp") elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "alpha.*") if(CMAKE_C_COMPILER MATCHES "gcc") set(NAN_CFLAGS "${NAN_CFLAGS} -mieee") else(CMAKE_C_COMPILER MATCHES "gcc") set(NAN_CFLAGS "${NAN_CFLAGS} -ieee") endif(CMAKE_C_COMPILER MATCHES "gcc") endif(CMAKE_SYSTEM_PROCESSOR MATCHES "i[0-9]86" AND NOT CMAKE_C_COMPILER MATCHES "gcc") [...] should give the same result (no -mieee-fp option used for gcc on i*86). The git master version should become the basis of a PLplot release in early 2018. Thanks once again for your key help with PLplot for the cutting-edge versions of Linux system software that you get with Fedora. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
