Re: [Plplot-devel] 2 fixes for libcsironn

2008-10-20 Thread Pieter-Jan Busschaert
> > > 2) in trunk/lib/nn/nncommon.c : circle_contains() > > > > line 90 : return hypot(c->x - p->x, c->y - p->y) <= c->r; > > > > should be changed to > > > > line 90 : return hypot(c->x - p->x, c->y - p->y) < c->r + 0.01; > > > > > > This is just a standard floating point equality checking bug

Re: [Plplot-devel] 2 fixes for libcsironn

2008-10-20 Thread Andrew Ross
Dear Pieter-Jan, Many thanks for spotting these issues with libcsironn. I have committed fixes to SVN. See below for comments. On Sun, Oct 19, 2008 at 08:55:43PM +0200, Pieter-Jan Busschaert wrote: > Hello, > > > I have recently been testing libcsironn (the version from plplot). > I have come

Re: [Plplot-devel] 2 fixes for libcsironn

2008-10-19 Thread Alan W. Irwin
On 2008-10-19 20:55+0200 Pieter-Jan Busschaert wrote: > Hello, > > > I have recently been testing libcsironn (the version from plplot). > I have come across 2 errors : > > 1) in trunk/lib/nn/delaunay.c : delaunay_circles_find() > > line 679 :if (tid < 0 || tid == nn) { > > should be c

[Plplot-devel] 2 fixes for libcsironn

2008-10-19 Thread Pieter-Jan Busschaert
Hello, I have recently been testing libcsironn (the version from plplot). I have come across 2 errors : 1) in trunk/lib/nn/delaunay.c : delaunay_circles_find() line 679 :if (tid < 0 || tid == nn) { should be changed to line 679 :if (tid < 0 || i == nn) { This bug l