Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-22 14:34-0400 Jim Dishaw wrote: > > >> On Jun 22, 2015, at 1:50 PM, Alan W. Irwin wrote: >> >>> On 2015-06-21 23:50-0400 Jim Dishaw wrote: >>> >>> I fixed the compilation error on cairo.c and I am working on a fix to cairo >>> so that it actually resizes the plot (at least for xcairo,

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 22, 2015, at 1:50 PM, Alan W. Irwin wrote: > >> On 2015-06-21 23:50-0400 Jim Dishaw wrote: >> >> I fixed the compilation error on cairo.c and I am working on a fix to cairo >> so that it actually resizes the plot (at least for xcairo, not sure when I >> can fix wincairo) when the wi

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-21 23:50-0400 Jim Dishaw wrote: > I fixed the compilation error on cairo.c and I am working on a fix to cairo > so that it actually resizes the plot (at least for xcairo, not sure when I > can fix wincairo) when the window changes size. > > I will also take a look at xwin when I get a

Re: [Plplot-devel] Bug fix to plbuf.c

I fixed the compilation error on cairo.c and I am working on a fix to cairo so that it actually resizes the plot (at least for xcairo, not sure when I can fix wincairo) when the window changes size. I will also take a look at xwin when I get a chance. I think the problem has to do with the seq

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-15 12:24-0400 Jim Dishaw wrote: > Attached is a patch series that implements the second solution. I tested the changes to xwin driver; however, I was not able to test tkwin, qt, or cairo. I will provide an update to wingcc separately. I didn’t touch the wxwidgets driver. > The xwin

Re: [Plplot-devel] Bug fix to plbuf.c

berg <mailto:p.d.rosenb...@gmail.com> > Cc: Alan W. Irwin <mailto:ir...@beluga.phys.uvic.ca>; PLplot development list > <mailto:Plplot-devel@lists.sourceforge.net>; Andrew Ross > <mailto:andrewr...@users.sourceforge.net> > Subject: Re: [Plplot-devel] Bug fix

Re: [Plplot-devel] Bug fix to plbuf.c

Cc: "Alan W. Irwin" ; "PLplot development list" ; "Andrew Ross" Subject: Re: [Plplot-devel] Bug fix to plbuf.c > On Jun 16, 2015, at 4:58 AM, Phil Rosenberg wrote: > > So how should we go about applying all this? Will we break some > drivers when it

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 16, 2015, at 4:58 AM, Phil Rosenberg wrote: > > So how should we go about applying all this? Will we break some > drivers when it is applied? If so do we need to have all drivers > prepared so that we can apply all the fixes together? > All function pointer are set to NULL during the

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-15 12:24-0400 Jim Dishaw wrote: > [...] Attached is a patch series that implements the second [elegant] solution. I tested the changes to xwin driver; however, I was not able to test tkwin, qt, or cairo. I will provide an update to wingcc separately. I didn’t touch the wxwidgets driv

Re: [Plplot-devel] Bug fix to plbuf.c

So how should we go about applying all this? Will we break some drivers when it is applied? If so do we need to have all drivers prepared so that we can apply all the fixes together? Phil On 16 June 2015 at 02:55, Jim Dishaw wrote: > And here is the wingcc patch series. I tested with cygwin and

Re: [Plplot-devel] Bug fix to plbuf.c

And here is the wingcc patch series.  I tested with cygwin and msvc and did not have the problem with multiple keypresses.  The wingcc driver does seem to have a problem when the window is made small.  It cuts off part of the plot. 0002-Updated-the-wingcc-driver-to-reflect-the-changes-for.patch De

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 14, 2015, at 1:40 PM, Jim Dishaw wrote: > > >> On Jun 14, 2015, at 5:19 AM, Alan W. Irwin wrote: >> >> On 2015-06-13 22:29-0400 Jim Dishaw wrote: >> >>> On Jun 13, 2015, at 2:11 PM, Jim Dishaw wrote: On Jun 13, 2015, at 1:13 PM, Phil Rosenberg >>>

Re: [Plplot-devel] Bug fix to plbuf.c

On 06/14/2015 05:59 PM, Alan W. Irwin wrote: > On 2015-06-14 13:40-0400 Jim Dishaw wrote: > >> []The aqt driver is a mystery. It does not use the plot buffer > nor does it look at the nopause member; however, it is an interactive > driver. It should work with just a NULL in the wait handler b

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-14 19:16-0400 Jim Dishaw wrote: > I am planning on making a native driver for macos x, though I am not sure if I can make the cutoff for 5.11.1 Hi Jim: Such a native Mac OS X device would be quite welcome. However, that's new development where the cutoff for pushing to the master bra

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 14, 2015, at 5:59 PM, Alan W. Irwin wrote: > >> On 2015-06-14 13:40-0400 Jim Dishaw wrote: >> >> []The aqt driver is a mystery. It does not use the plot buffer > nor does it look at the nopause member; however, it is an interactive > driver. It should work with just a NULL in the

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-14 13:40-0400 Jim Dishaw wrote: > []The aqt driver is a mystery. It does not use the plot buffer nor does it look at the nopause member; however, it is an interactive driver. It should work with just a NULL in the wait handler because the EOP will be called only once. The dg300 is

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 14, 2015, at 5:19 AM, Alan W. Irwin wrote: > > On 2015-06-13 22:29-0400 Jim Dishaw wrote: > >> >>> On Jun 13, 2015, at 2:11 PM, Jim Dishaw wrote: >>> >>> >>> On Jun 13, 2015, at 1:13 PM, Phil Rosenberg >> > wrote: >>> Hmmm Then h some

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-13 22:29-0400 Jim Dishaw wrote: > >> On Jun 13, 2015, at 2:11 PM, Jim Dishaw wrote: >> >> >> On Jun 13, 2015, at 1:13 PM, Phil Rosenberg > > wrote: >> >>> Hmmm >>> Then h some more >>> Followed by an ummm or two. >>> >>> As you say Jim, clearly thing

Re: [Plplot-devel] Bug fix to plbuf.c

for > deciding about the wait for input is one spot. > > Regardless of the solution, some changes to the drivers will be required. > Solution 2 will touch all the drivers (at a minimum to add a NULL to the > dispatch table). Solution 1 adds code to the drivers while solution 2 > removes

Re: [Plplot-devel] Bug fix to plbuf.c

..@dishaw.org> >> Sent: ‎13/‎06/‎2015 17:55 >> To: Alan W. Irwin <mailto:ir...@beluga.phys.uvic.ca> >> Cc: PLplot development list <mailto:Plplot-devel@lists.sourceforge.net> >> Subject: Re: [Plplot-devel] Bug fix to plbuf.c >> >> >>>

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-13 17:15-0400 Jim Dishaw wrote: > > >> On Jun 13, 2015, at 3:25 PM, Phil Rosenberg wrote: >> >> Okay, well if you need any help or testing let me know. >> >> Something that I haven't seen up to now (but maybe I never looked hard >> enough) is a spec sheet for how to write a driver, I.

Re: [Plplot-devel] Bug fix to plbuf.c

19:11 > To: Phil Rosenberg > Cc: Alan W. Irwin; PLplot development list > Subject: Re: [Plplot-devel] Bug fix to plbuf.c > > >> On Jun 13, 2015, at 1:13 PM, Phil Rosenberg wrote: >> >> Hmmm >> Then h some more >> Followed by an ummm or two. &

Re: [Plplot-devel] Bug fix to plbuf.c

nt: ‎13/‎06/‎2015 19:11 To: "Phil Rosenberg" Cc: "Alan W. Irwin" ; "PLplot development list" Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 1:13 PM, Phil Rosenberg wrote: Hmmm Then h some more Followed by an ummm or two. As you s

Re: [Plplot-devel] Bug fix to plbuf.c

for input state on a redraw event from the callback. > Phil > From: Jim Dishaw > Sent: ‎13/‎06/‎2015 17:55 > To: Alan W. Irwin > Cc: PLplot development list > Subject: Re: [Plplot-devel] Bug fix to plbuf.c > > >>> On Jun 13, 2015, at 12:03 PM, Jim Dishaw wrote:

Re: [Plplot-devel] Bug fix to plbuf.c

development list" Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 12:03 PM, Jim Dishaw wrote: On Jun 11, 2015, at 12:29 AM, Jim Dishaw wrote: On Jun 10, 2015, at 11:30 PM, Alan W. Irwin wrote: Just to confirm that I just now played a lot with resizing of examp

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 13, 2015, at 12:03 PM, Jim Dishaw wrote: > > >> On Jun 11, 2015, at 12:29 AM, Jim Dishaw > > wrote: >> >>> >>> On Jun 10, 2015, at 11:30 PM, Alan W. Irwin >> > wrote: > >>> Just to confirm that I just now played a lot with r

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 11, 2015, at 12:29 AM, Jim Dishaw wrote: > >> >> On Jun 10, 2015, at 11:30 PM, Alan W. Irwin >> wrote: >> Just to confirm that I just now played a lot with resizing of >> >> examples/c/x01c -dev xwin >> >> for 5.10.0, 5.11.0, and git master tip (including your recent commit), >>

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 10, 2015, at 11:30 PM, Alan W. Irwin wrote: > > On 2015-06-10 19:58-0400 Jim Dishaw wrote: > >>> On Jun 10, 2015, at 3:57 AM, Alan W. Irwin >>> wrote: > >>> I am sufficiently concerned by your explanation of this fix above that >>> I am now beginning to wonder a bit if it was necess

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-10 19:58-0400 Jim Dishaw wrote: >> On Jun 10, 2015, at 3:57 AM, Alan W. Irwin wrote: >> I am sufficiently concerned by your explanation of this fix above that >> I am now beginning to wonder a bit if it was necessary. Of course, I >> could be just missing something, but I would appre

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 10, 2015, at 3:57 AM, Alan W. Irwin wrote: > >> On 2015-06-09 23:10-0400 Jim Dishaw wrote: >> >> >>> On Jun 9, 2015, at 10:39 PM, Alan W. Irwin >>> wrote: >>> >>> On 2015-06-09 18:18-0400 Jim Dishaw wrote: >>> Attached is a patch series that corrects a NUL termination bug

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-09 23:10-0400 Jim Dishaw wrote: > >> On Jun 9, 2015, at 10:39 PM, Alan W. Irwin wrote: >> >> On 2015-06-09 18:18-0400 Jim Dishaw wrote: >> >>> Attached is a patch series that corrects a NUL termination bug in >> the plot buffer that I discovered while working on the windows GDI >> driv

Re: [Plplot-devel] Bug fix to plbuf.c

> On Jun 9, 2015, at 10:39 PM, Alan W. Irwin wrote: > > On 2015-06-09 18:18-0400 Jim Dishaw wrote: > >> Attached is a patch series that corrects a NUL termination bug in > the plot buffer that I discovered while working on the windows GDI > driver. > > Hi Jim: > > I applied this result to a p

Re: [Plplot-devel] Bug fix to plbuf.c

On 2015-06-09 18:18-0400 Jim Dishaw wrote: > Attached is a patch series that corrects a NUL termination bug in the plot buffer that I discovered while working on the windows GDI driver. Hi Jim: I applied this result to a private branch using "git am", styled this result (which was very easy to d

[Plplot-devel] Bug fix to plbuf.c

Attached is a patch series that corrects a NUL termination bug in the plot buffer that I discovered while working on the windows GDI driver. I apologize that it has not been uncrustified. Is cygwin required to run the script? 0003-Fixed-a-NUL-termination-bug-in-plbuf.c.patch Description: Bin