Re: [Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-15 Thread Alan W. Irwin
On 2008-12-15 10:06- Andrew Ross wrote: > > Alan, > > There are also quite a few malloc / realloc calls which explicitly cast > the output as (short *) rather than (int *). To avoid any problems these > also need fixing. I've been through and checked this all. I think the > xfig driver is now

Re: [Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-15 Thread Andrew Ross
Alan, There are also quite a few malloc / realloc calls which explicitly cast the output as (short *) rather than (int *). To avoid any problems these also need fixing. I've been through and checked this all. I think the xfig driver is now ok. I've submitted your patches + my addition fixes to sv

Re: [Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-14 Thread Alan W. Irwin
Thanks, Terrence, for that most useful explanation. Alan __ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation

Re: [Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-14 Thread trc
Alan W. Irwin wrote: > On 2008-12-14 14:02-0800 Alan W. Irwin wrote: > >> [...]This patch is only part of the story. > > --- drivers/xfig.c 2008-12-14 14:40:29.0 -0800 > +++ drivers/xfig.c~ 2008-12-14 12:31:45.0 -0800 > @@ -414,7 +414,7 @@ > flushbuffer(PLStream *pls) >

Re: [Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-14 Thread Alan W. Irwin
On 2008-12-14 14:02-0800 Alan W. Irwin wrote: > [...]This patch is only part of the story. --- drivers/xfig.c 2008-12-14 14:40:29.0 -0800 +++ drivers/xfig.c~ 2008-12-14 12:31:45.0 -0800 @@ -414,7 +414,7 @@ flushbuffer(PLStream *pls) { PLDev *dev = pls->dev; - int

[Plplot-devel] Initial patch for the recently discovered xfig.c bug

2008-12-14 Thread Alan W. Irwin
On 2008-12-14 02:51-0800 Alan W. Irwin wrote: [...]I had to turn off the -dev xfig test > because of a spectacular error (first time I have ever seen a glibc > backtrace!) generated by example 27 for that device. I have looked into this error with gdb, and the problem is the bufflen and count wer