Re: Implementing ActionRequest and RenderRequest in the same class

John, I agree the current bridges (struts and jsf) usage of instanceof to distinguish is wrong! One should never use instanceof on interfaces to distinguish which is implemented by an instance. I created a JIRA issue for this and already fixed the jsf and struts bridge in svn, see: http://i

Re: Implementing ActionRequest and RenderRequest in the same class

Thanks to Patrick, Elliot, and David for your input. All very helpful. In discussing things with the developers of the portal in question, it sounds like they are going to modify their implementation to use two different classes given that this appears to a common assumption. I like the idea

Re: Implementing ActionRequest and RenderRequest in the same class

John, I agree with Elliot's solution that some kind of request attribute which is injected during the initial processAction or doRender invocation is the way to go if you really need to determine the request type. This will ensure the behavior no matter what implementation choice the portal

Re: Implementing ActionRequest and RenderRequest in the same class

Hi John, John Lewis wrote: In a few places in the framework, we have code that generally handles PortletRequest objects, but then may need to do some special logic depending on if it is an ActionRequest or RenderRequest. In those cases, we test it with instanceof and proceed accordingly. Wh

Re: Implementing ActionRequest and RenderRequest in the same class

Implementing both Interfaces in one Class is, in my opinion, certainly not what was intended by the JSR168 group. There's a reason for having two Interfaces: so we can distinguish them. Since both Interfaces are implemented in the same class, you should be able to do setRenderParameter during the