[Podofo-users] PdfVariant: m_eDataType explained & Unknown sentinel value added

2019-01-24 Thread Matthew Brincke
Hi zyx, hello all, > On 24 January 2019 at 18:55 zyx wrote: > > > Hi, ... snip ... > > > @zyx: Are you still vetoing that change of Francesco's (making > > Unknown equal to 0xff in EPdfDataType)? > > My complain from the past was about the compiler warnings (as Francesco > pointed out

Re: [Podofo-users] [PATCH 1/5] PdfVariant: m_eDataType is really a EPdfDataType

2019-01-24 Thread zyx
Hi, On Thu, 2019-01-24 at 17:43 +0100, Matthew Brincke wrote: > It isn't the case that Michal wrote they were the same, he only wrote > they are stored the same yes, I know. My test-in-action showed that what is stored and how it works are two different things. To make it

Re: [Podofo-users] [PATCH 1/5] PdfVariant: m_eDataType is really a EPdfDataType

2019-01-24 Thread Matthew Brincke
Hi zyx, hello all, > On 24 January 2019 at 12:13 zyx wrote: > > > On Wed, 2019-01-23 at 20:09 +0100, Michal Sudolsky wrote: > > I am tempted to note that -1 is stored in 8-bit integer in exactly > > same way as 0xFF. > it seems to me (after reading the remainder of zyx' post) that I should

Re: [Podofo-users] [PATCH 1/5] PdfVariant: m_eDataType is really a EPdfDataType

2019-01-24 Thread Michal Sudolsky
On Thu, Jan 24, 2019 at 12:14 PM zyx wrote: > On Wed, 2019-01-23 at 20:09 +0100, Michal Sudolsky wrote: > > I am tempted to note that -1 is stored in 8-bit integer in exactly > > same way as 0xFF. > > Hi, > I used the code below with gcc 8.1.1 with this result (the result will > make

Re: [Podofo-users] [PATCH 1/5] PdfVariant: m_eDataType is really a EPdfDataType

2019-01-24 Thread zyx
On Wed, 2019-01-23 at 20:09 +0100, Michal Sudolsky wrote: > I am tempted to note that -1 is stored in 8-bit integer in exactly > same way as 0xFF. Hi, I used the code below with gcc 8.1.1 with this result (the result will make sense when the code is read): [0] is -1; same:0/1/0 as