From: Ryan Ackley [EMAIL PROTECTED]
I am definitely -1 on setting up a complex process with checkstyle. The
only
benefit I see of code formatting is to make the code readable with the
correct tabbing. I don't know of any other benefits because I have never
used a pretty printer. But this is
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Glen Stampoultzis wrote:
Hard to plan until you understand the low level stuff well. Current plan:
1. Implement all required records to get a basic chart done (there's a lot
of these).
2. Analyse record structure.
3. Have a first pass at writing a high-level API
4. Refine (refactor) until
Ok, it makes sense.
Since Rainer is (correctly) concerned that he won't recognize the code after
being mand pretty, let's say what this pretty thing should do.
1. Tabs - spaces
2. Correct CR/LF
3. Reduce to 80 lines width longer lines.
Yup! Thazz about it! It will also do some other
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Consider adding these features to Centipede (the build system POI uses)
or even checkstyle.
If anyone is interested enough I have a scripting challenge for you.
I'm pretty sure it can be done. Add this warning/reformat solution to
Loginfo in CVS. This script runs on checkin
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Cept that well...the plan is the same except mine includes documentation
:-D
Huh! Let's make 'em figure out the low level record structure themselves.
Lazy bums.
-- Glen
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Yup! Thazz about it! It will also do some other minor things like turn
if (blabla blabla)
blabla();
to
if (blabla blabla) {
blabla();
}
Arrgh! Either leave it as it is, because this is the most concise
and comprehensive way to put it or reformat it to
if (blabla blabla)
{
Discussion ended (per original announcement that the issue would be
killed if this disintegrated into a discussion on brace placement/etc).
There will be no pretty printer. We'll just have to live with ugly
code. Sorry, thanks for playing.
PedanticAndIrrelevantDiscussionException thrown at
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8858.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Andrew C. Oliver [EMAIL PROTECTED] wrote:
Discussion ended (per original announcement that the issue would be
killed if this disintegrated into a discussion on brace placement/etc).
There will be no pretty printer. We'll just have to live with ugly
code. Sorry, thanks for playing.
acoliver02/05/14 11:13:33
Modified:src/scratchpad/src/org/apache/poi/generator RecordUtil.java
Log:
added support for in-lined test data
Revision ChangesPath
1.9 +21 -3
jakarta-poi/src/scratchpad/src/org/apache/poi/generator/RecordUtil.java
Index:
acoliver02/05/14 17:56:18
Modified:src/scratchpad/src/org/apache/poi/generator
FieldIterator.java RecordUtil.java
Log:
Support test expression
Revision ChangesPath
1.7 +11 -4
acoliver02/05/14 17:58:26
Added: src/records/definitions series_text_record.xml
Log:
support series text
Revision ChangesPath
1.1 jakarta-poi/src/records/definitions/series_text_record.xml
Index: series_text_record.xml
20 matches
Mail list logo
