DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42474>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42474 Summary: Patches for a couple of bugs in HSLF Product: POI Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: HSLF AssignedTo: poi-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] 1. Incorrect matching of notes to slides This is a long standing problem apparently, I noticed a TODO comment about it... anyway, after a bit of trial and error the problem seems to be that for some PPT files the SlidePersistAtom from the note's SlideAtomSet has a wrong slideIdentifier sometimes, so matching it to the associated slide is impossible. But if you look at the NotesAtom from the actual Notes record (retrieved via getCoreRecordForSAS()) it has the correct slideId, so that's what I use in my patch. I don't know yet why SlideAtomSet.getSlidePersistAtom().getSlideIdentifier() is different from Notes.getNotesAtom().getSlideId(), maybe that's the real bug and my patch is merely working around it? Someone more knowledgeable could shed some light on whether these two values are supposed to be always equal, in the meantime this patch works perfectly for all my test cases which previously exhibited incorrect note->slide association. 2. NPE in RichTextRun.isBold() when the RichTextRun comes from a Notes model object The Notes object wasn't doing setSheet(this) on the text runs it returned, causing a NPE inside RichTextRun.isCharFlagsTextPropVal() when any style accessor is called, because it tries to get the style info from the master sheet if not present. However, doing setSheet() in Notes was not enough, it merely moved the NPE a couple of lines down because NotesMaster objects are not yet implemented in HSLF, so I had to add a few null checks in RichTextRun too. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
