Re: [poppler] pdftocairo - Updated Patches

2010-08-19 Thread Albert Astals Cid
A Dijous, 19 d'agost de 2010, Stefan Thomas va escriure: > Hey again, > > > Following modification can drop the page number suffix in > > output filename when "split" flag is disabled. Stefan, could > > you review? > > Makes sense and works great! Thanks! > > A Dissabte, 31 de juliol de 2010,

Re: [poppler] Help with pdftohtml background image resolution

2010-08-19 Thread Albert Astals Cid
A Diumenge, 15 d'agost de 2010, mpsuz...@hiroshima-u.ac.jp va escriure: > On Sat, 14 Aug 2010 21:56:02 +0100 > > Albert Astals Cid wrote: > >> Attached is a preliminary patch to add "-usesplash" > >> option to pdftohtml, which creates background image > >> by SplashOutputDev. > > > >That's someth

Re: [poppler] pdftocairo - Updated Patches

2010-08-19 Thread mpsuzuki
On Thu, 19 Aug 2010 11:00:48 +0200 Stefan Thomas wrote: >> Following modification can drop the page number suffix in >> output filename when "split" flag is disabled. Stefan, could >> you review? > >Makes sense and works great! Thanks! Thank you for review. >A Dissabte, 31 de juliol de 2010, Adr

Re: [poppler] pdftocairo - Updated Patches

2010-08-19 Thread Stefan Thomas
Hey again, Following modification can drop the page number suffix in output filename when "split" flag is disabled. Stefan, could you review? Makes sense and works great! Thanks! A Dissabte, 31 de juliol de 2010, Adrian Johnson va escriure: I've just done some testing with the patches and

Re: [poppler] Patches for SplashBitmap/PNGWriter

2010-08-19 Thread Stefan Thomas
Moving the `delete[] row;` should avoid requiring two identical lines: delete[] row; + if (!writer->close()) { +return splashErrGeneric; + } Yes, but libjpeg keeps a reference to row and may access it during jpeg_finish_compress(). So deleting row before writer->clos

Re: [poppler] Patches for SplashBitmap/PNGWriter

2010-08-19 Thread Reece Dunn
On 19 August 2010 09:02, Stefan Thomas wrote: > >> There are memory leaks in [...] >> >> When the writer fails to close, right? > > Oh yes, sorry about that! An additional delete[] row; should clean it up > nicely. Moving the `delete[] row;` should avoid requiring two identical lines: dele

Re: [poppler] Patches for SplashBitmap/PNGWriter

2010-08-19 Thread Stefan Thomas
There are memory leaks in [...] When the writer fails to close, right? Oh yes, sorry about that! An additional delete[] row; should clean it up nicely. On 7/16/2010 3:32 PM, Albert Astals Cid wrote: A Dissabte, 10 de juliol de 2010, Stefan Thomas va escriure: Hello! I've got two new p