A Dijous, 19 d'agost de 2010, Stefan Thomas va escriure:
Moving the `delete[] row;` should avoid requiring two identical lines:
delete[] row;
+ if (!writer-close()) {
+return splashErrGeneric;
+ }
Yes, but libjpeg keeps a reference to row and may access it
There are memory leaks in [...]
When the writer fails to close, right?
Oh yes, sorry about that! An additional delete[] row; should clean it up
nicely.
On 7/16/2010 3:32 PM, Albert Astals Cid wrote:
A Dissabte, 10 de juliol de 2010, Stefan Thomas va escriure:
Hello!
I've got two new
On 19 August 2010 09:02, Stefan Thomas tho...@txtbear.com wrote:
There are memory leaks in [...]
When the writer fails to close, right?
Oh yes, sorry about that! An additional delete[] row; should clean it up
nicely.
Moving the `delete[] row;` should avoid requiring two identical lines:
A Dimarts, 20 de juliol de 2010, Stefan Thomas va escriure:
Merged patches into one and fixed last two compiler warnings.
@Albert: Assuming you agree with me on the duplicate code issue, this
should be ready to be committed.
There are memory leaks in
+ if (!writer-close()) {
+
A Dissabte, 10 de juliol de 2010, Stefan Thomas va escriure:
Hello!
I've got two new patches for the cause.
The first one adds transparent PNG support to PNGWriter and
SplashBitmap. The uses for this are varied and many, so I think it makes
sense to add this to the mainline, even though I
Hey Albert,
Seems like it duplicates some code from the other method, would it be possible
to merge them a bit more?
I tried with a single function first. Too many special cases and you
don't want any if's in those performance-sensitive inner loops.
Eventually I split it into two
Hello!
I've got two new patches for the cause.
The first one adds transparent PNG support to PNGWriter and
SplashBitmap. The uses for this are varied and many, so I think it makes
sense to add this to the mainline, even though I don't have the pdftoppm
patch to go along with it. (We're using
