Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-28 Thread Bryan Vyhmeister
I am re-posting about this change for rsync since it has been several more weeks. I appreciate everyone who has responded. I would like to see anyone else who might have objections to this speak up. I also checked around to see what FreeBSD and Debian are doing and both include zstd, lz4, and

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-09 Thread Stuart Henderson
Re upgrade paths / defaults (i.e. whether to have -minimal as a low-dep option and include zstd etc otherwise, or whether to avoid them by default and have -full as the version with run deps) - I think it really depends on what would be considered acceptable by whoever it was that complained

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-08 Thread Jeremie Courreges-Anglas
On Mon, Jul 08, 2024 at 12:26:52PM -0700, Bryan Vyhmeister wrote: > This patch to switch rsync to being built by default with iconv, lz4, > and zstd and then also build a -minimal flavor which removes all of > those has been floating around on ports@ for several weeks. Any further > comments?

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-08 Thread Bryan Vyhmeister
This patch to switch rsync to being built by default with iconv, lz4, and zstd and then also build a -minimal flavor which removes all of those has been floating around on ports@ for several weeks. Any further comments? I suspect switching to zstd compression (which would be the default once this

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-03 Thread Bryan Vyhmeister
On Tue, Jul 02, 2024 at 10:29:14PM +0200, Jeremie Courreges-Anglas wrote: > People were complaining that it pushed too many deps, both for the > package and for the port. The 'minimal' FLAVOR should cover that. > > > @@ -35,7 +33,10 @@ CONFIGURE_ARGS =--disable-lz4 \ > >

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-02 Thread Jeremie Courreges-Anglas
On Tue, Jul 02, 2024 at 10:24:43AM -0700, Bryan Vyhmeister wrote: > On Tue, Jul 02, 2024 at 09:39:57AM +0100, Stuart Henderson wrote: > > On 2024/07/01 18:32, Bryan Vyhmeister wrote: > > > I updated the title based on the discussion and what this patch actually > > > does now. I have a particular

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-02 Thread Bryan Vyhmeister
On Tue, Jul 02, 2024 at 09:39:57AM +0100, Stuart Henderson wrote: > On 2024/07/01 18:32, Bryan Vyhmeister wrote: > > I updated the title based on the discussion and what this patch actually > > does now. I have a particular project that needs zstd compression with > > rsync. I can modify the port

Re: [PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-02 Thread Stuart Henderson
On 2024/07/01 18:32, Bryan Vyhmeister wrote: > I updated the title based on the discussion and what this patch actually > does now. I have a particular project that needs zstd compression with > rsync. I can modify the port in my own tree to build zstd into the port > but I would prefer not to

[PATCH] rsync add zstd,lz4,iconv options as default and -minimal flavor

2024-07-01 Thread Bryan Vyhmeister
I updated the title based on the discussion and what this patch actually does now. I have a particular project that needs zstd compression with rsync. I can modify the port in my own tree to build zstd into the port but I would prefer not to have to maintain a private package repository. Based on