Re: PATCH: emulators/qemu

2008-10-30 Thread Todd T. Fries
Hardly. It's syntactic sugar twiddling the port into better compliance with porting standards. I see no kqemu here.. nor code changes.. -- Todd Fries .. [EMAIL PROTECTED] _ | \ 1.636.410.0632 (voice) | Fre

Re: PATCH: emulators/qemu

2008-10-30 Thread Marco Peereboom
does this fix kqemu on amd64 generic.mp? On Thu, Oct 30, 2008 at 07:30:56PM +0100, Giovanni Bechis wrote: > Mikolaj Kucharski wrote: >> Hi, >> >> - use SUBST_CMD >> - fix path in README.OpenBSD for qemu-ifup >> - do not hardcode /usr/local in README.OpenBSD >> - @bin markers - update-plist >> - pa

Re: PATCH: emulators/qemu

2008-10-30 Thread Giovanni Bechis
Mikolaj Kucharski wrote: Hi, - use SUBST_CMD - fix path in README.OpenBSD for qemu-ifup - do not hardcode /usr/local in README.OpenBSD - @bin markers - update-plist - patch-level bump Latest patch which fixes path in README.OpenBSD. Cheers Giovanni Index: Makefile =

Re: PATCH: emulators/qemu

2008-10-30 Thread Giovanni Bechis
Mikolaj Kucharski wrote: Okay, in that case why patches have LOCALBASE and readme PREFIX? For me it looks inconsistent. As you could see in my original patch I would go for LOCALBASE only. Could somone shed some light for me please on this? LOCALBASE is where other port have been installed, PRE

Re: PATCH: emulators/qemu

2008-10-29 Thread Giovanni Bechis
Mikolaj Kucharski wrote: Some LOCALBASE need to be PREFIX. But in this case should be.. ? I think it should be something like this diff. Cheers Giovanni Index: Makefile === RCS file: /cvs/ports/emulators/qemu/Makefile,v retrie

Re: PATCH: emulators/qemu

2008-10-29 Thread Mikolaj Kucharski
On Wed, Oct 29, 2008 at 12:50:53PM +0100, Giovanni Bechis wrote: > Mikolaj Kucharski wrote: >>> Some LOCALBASE need to be PREFIX. >> >> But in this case should be.. ? >> > I think it should be something like this diff. Okay, in that case why patches have LOCALBASE and readme PREFIX? For me it loo

Re: PATCH: emulators/qemu

2008-10-29 Thread Mikolaj Kucharski
On Wed, Oct 29, 2008 at 09:48:31AM +0100, Antoine Jacoutot wrote: > On Wed, 29 Oct 2008, Mikolaj Kucharski wrote: > > > Hi, > > > > - use SUBST_CMD > > - fix path in README.OpenBSD for qemu-ifup > > - do not hardcode /usr/local in README.OpenBSD > > Some LOCALBASE need to be PREFIX. But in this

Re: PATCH: emulators/qemu

2008-10-29 Thread Antoine Jacoutot
On Wed, 29 Oct 2008, Mikolaj Kucharski wrote: > Hi, > > - use SUBST_CMD > - fix path in README.OpenBSD for qemu-ifup > - do not hardcode /usr/local in README.OpenBSD Some LOCALBASE need to be PREFIX. -- Antoine

Re: PATCH: emulators/qemu

2008-10-29 Thread Giovanni Bechis
Mikolaj Kucharski ha scritto: Hi, - use SUBST_CMD - fix path in README.OpenBSD for qemu-ifup - do not hardcode /usr/local in README.OpenBSD Shouldn't it be replaced by ${PREFIX} ? Cheers Giovanni

PATCH: emulators/qemu

2008-10-28 Thread Mikolaj Kucharski
Hi, - use SUBST_CMD - fix path in README.OpenBSD for qemu-ifup - do not hardcode /usr/local in README.OpenBSD - @bin markers - update-plist - patch-level bump -- best regards q# Index: Makefile === RCS file: /cvs/ports/emulators/qem