On Wed, May 22, 2024 at 07:52:39PM +0100, Edd Barrett wrote:
> On Sun, May 19, 2024 at 12:45:45AM -0400, Russ Sharek wrote:
> > > # Adapted from the test target in ${WRKSRC}/Makefile
> > > MODGO_TEST_TARGET = cd ${WRKSRC} && \
> > > CGO_ENABLED=1 ${MODGO_CMD} test -count 1 -v -tags=test
>
On Thu, Aug 29, 2024 at 10:11:40PM -0400, Russ Sharek wrote:
> I could use some input and guidance on how to handle the do-install:
> thing Edd mentioned. Currently, the port passes all tests with the
> MODGO_TEST_TARGET which was previously added.
Instead of setting MODGO_TEST_TARGET, it would
> Instead of setting MODGO_TEST_TARGET, it would be more
> ports-idiomatic/clearer
> to use a `do-test` target like:
>
> ```
> do-test:
> cd ${WRKSRC} && CGO_ENABLED=1 ${MODGO_CMD} test -count 1 -v \
> -tags=test -coverprofile="cover.out" ./...
> ```
>
> Tests are passing lik
> Did you by any chance write
>
> If you did, then I think that's the problem. Everything after the colon are
> prerequisites (dependencies) to the target (do-test), see here[1].
> Prerequisites are simply other targets you'd want executed *before* the
> do-test target. So in this case make tries
2024-08-30T20:20:25Z Russ Sharek :
Instead of setting MODGO_TEST_TARGET, it would be more
ports-idiomatic/clearer
to use a `do-test` target like:
```
do-test:
cd ${WRKSRC} && CGO_ENABLED=1 ${MODGO_CMD} test -count 1 -v \
-tags=test -coverprofile="cover.out" ./...
```
Tests are pass
