archivers/snappy: unbreak on sparc64

2023-10-16 Thread Theo Buehler
For some reason ports-gcc can't find "lz4.h", so pass -I in CXXFLAGS. Then there's the usual missing include thing in gtest. I should see if I can upstream that... I don't think this changes the package where it already builds, but I can bump REVISION if that's preferred. Index: Makefile

Re: archivers/snappy: unbreak on sparc64

2023-10-16 Thread Klemens Nanni
On Mon, Oct 16, 2023 at 09:47:42PM +0200, Theo Buehler wrote: > For some reason ports-gcc can't find "lz4.h", so pass -I in CXXFLAGS. > Then there's the usual missing include thing in gtest. I should see if I > can upstream that... You could contain it with to avoid subtle change on clang archs, n

Re: archivers/snappy: unbreak on sparc64

2023-10-16 Thread Theo Buehler
On Mon, Oct 16, 2023 at 08:36:07PM +, Klemens Nanni wrote: > On Mon, Oct 16, 2023 at 09:47:42PM +0200, Theo Buehler wrote: > > For some reason ports-gcc can't find "lz4.h", so pass -I in CXXFLAGS. > > Then there's the usual missing include thing in gtest. I should see if I > > can upstream that

Re: archivers/snappy: unbreak on sparc64

2023-10-16 Thread Klemens Nanni
On Mon, Oct 16, 2023 at 10:51:37PM +0200, Theo Buehler wrote: > sorry for missing that. > > we should keep the existing CXXFLAGS, especially -O2 -pipe. This diff > no dynamic export changes and doesn't change sizees: > > 38075 164840 39763 9b53../build-amd64/libsnappy.so > 38075

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Stuart Henderson
On 2023/10/16 21:07, Klemens Nanni wrote: > OK kn when that works on sparc64 for you and got wrapped in a > CHOSEN_COMPILER or MACHINE_ARCH check. CHOSEN_COMPILER is messy because it has to go after the final .include Using MACHINE_ARCH and enumerating the base-gcc archs is a terrible idea for t

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Theo Buehler
On Tue, Oct 17, 2023 at 03:27:26PM +0100, Stuart Henderson wrote: > On 2023/10/16 21:07, Klemens Nanni wrote: > > OK kn when that works on sparc64 for you and got wrapped in a > > CHOSEN_COMPILER or MACHINE_ARCH check. > > CHOSEN_COMPILER is messy because it has to go after the final > .include >

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Klemens Nanni
On Tue, Oct 17, 2023 at 04:32:19PM +0200, Theo Buehler wrote: > On Tue, Oct 17, 2023 at 03:27:26PM +0100, Stuart Henderson wrote: > > On 2023/10/16 21:07, Klemens Nanni wrote: > > > OK kn when that works on sparc64 for you and got wrapped in a > > > CHOSEN_COMPILER or MACHINE_ARCH check. > > > > C

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Stuart Henderson
On 2023/10/17 17:36, Klemens Nanni wrote: > On Tue, Oct 17, 2023 at 04:32:19PM +0200, Theo Buehler wrote: > > On Tue, Oct 17, 2023 at 03:27:26PM +0100, Stuart Henderson wrote: > > > On 2023/10/16 21:07, Klemens Nanni wrote: > > > > OK kn when that works on sparc64 for you and got wrapped in a > > >

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Theo Buehler
On Tue, Oct 17, 2023 at 07:07:12PM +0100, Stuart Henderson wrote: > On 2023/10/17 17:36, Klemens Nanni wrote: > > On Tue, Oct 17, 2023 at 04:32:19PM +0200, Theo Buehler wrote: > > > On Tue, Oct 17, 2023 at 03:27:26PM +0100, Stuart Henderson wrote: > > > > On 2023/10/16 21:07, Klemens Nanni wrote: >

Re: archivers/snappy: unbreak on sparc64

2023-10-17 Thread Klemens Nanni
On Tue, Oct 17, 2023 at 07:07:12PM +0100, Stuart Henderson wrote: > I think this is a better fix (checked there's no change to the produced > package so I didn't bump). I concur, thanks. OK kn > > Index: Makefile > === > RCS file: /