check-lib-depends and modules' *_WANTLIB

2023-03-07 Thread Omar Polo
When regenerating WANTLIBs I usually comment/remove the WANTLIB from a port' Makefile, run `make port-lib-depends-check' and copy its output back into the makefile. This does not work "properly" for some ports, for e.g. the ones that use a *_WANTLIB variable defined by a module. Diff below adds a

Re: check-lib-depends and modules' *_WANTLIB

2023-09-03 Thread Omar Polo
(+cc semarie@ for cargo.port.mk) On 2023/08/21 14:57:04 +0200, Marc Espie wrote: > [...] > > > On 2023/03/07 14:05:19 +0100, Omar Polo wrote: > > > > When regenerating WANTLIBs I usually comment/remove the WANTLIB from a > > > > port' Makefile, run `make port-lib-depends-check' and copy its outp

Re: check-lib-depends and modules' *_WANTLIB

2023-09-03 Thread Omar Polo
On 2023/09/03 10:32:00 +0200, Omar Polo wrote: > I considered making the variable more like SUBST_VARS (i.e. just a > list of variable names) but then we loose the ability to express -F > which can be handy. Or maybe I'm overthinking it. just as I sent the email I noticed that my cargo.port.mk d

Re: check-lib-depends and modules' *_WANTLIB

2023-09-03 Thread Sebastien Marie
On Sun, Sep 03, 2023 at 10:44:51AM +0200, Omar Polo wrote: > On 2023/09/03 10:32:00 +0200, Omar Polo wrote: > > I considered making the variable more like SUBST_VARS (i.e. just a > > list of variable names) but then we loose the ability to express -F > > which can be handy. Or maybe I'm overthink

Re: check-lib-depends and modules' *_WANTLIB

2023-09-03 Thread Omar Polo
On 2023/09/03 12:07:27 +0200, Sebastien Marie wrote: > On Sun, Sep 03, 2023 at 10:44:51AM +0200, Omar Polo wrote: > > On 2023/09/03 10:32:00 +0200, Omar Polo wrote: > > > I considered making the variable more like SUBST_VARS (i.e. just a > > > list of variable names) but then we loose the ability

Re: check-lib-depends and modules' *_WANTLIB

2023-09-14 Thread Omar Polo
friendly ping, reattaching the two patches. Index: infrastructure/mk/bsd.port.mk === RCS file: /home/cvs/ports/infrastructure/mk/bsd.port.mk,v retrieving revision 1.1621 diff -u -p -r1.1621 bsd.port.mk --- infrastructure/mk/bsd.port.m

Re: check-lib-depends and modules' *_WANTLIB

2023-09-14 Thread Marc Espie
On Thu, Sep 14, 2023 at 03:09:00PM +0200, Omar Polo wrote: > friendly ping, reattaching the two patches. > > Index: infrastructure/mk/bsd.port.mk > === > RCS file: /home/cvs/ports/infrastructure/mk/bsd.port.mk,v > retrieving revision

Re: check-lib-depends and modules' *_WANTLIB

2023-08-18 Thread Omar Polo
ping (+cc espie) On 2023/03/07 14:05:19 +0100, Omar Polo wrote: > When regenerating WANTLIBs I usually comment/remove the WANTLIB from a > port' Makefile, run `make port-lib-depends-check' and copy its output > back into the makefile. This does not work "properly" for some ports, > for e.g. the

Re: check-lib-depends and modules' *_WANTLIB

2023-08-18 Thread Omar Polo
On 2023/08/18 09:56:01 +0200, Omar Polo wrote: > ping (+cc espie) sorry for typoing your email address! > On 2023/03/07 14:05:19 +0100, Omar Polo wrote: > > When regenerating WANTLIBs I usually comment/remove the WANTLIB from a > > port' Makefile, run `make port-lib-depends-check' and copy its