galculator produces three scary gcc warnings:

galculator-1.3.1/src/callbacks.c:152: warning: cast from pointer to integer of 
different size
galculator-1.3.1/src/callbacks.c:159: warning: cast from pointer to integer of 
different size
galculator-1.3.1/src/callbacks.c:911: warning: cast from pointer to integer of 
different size

I am fairly confident that these are all harmless, as they are cases
where an int is transported through a pointer API (i.e., int ->
pointer -> int), and should simply be shut up by using the appropriate
glib macros.

Somebody should take a second look, though.

--- src/callbacks.c.orig        Thu Jul  3 17:39:46 2008
+++ src/callbacks.c     Thu Jul  3 21:58:11 2008
@@ -148,15 +148,15 @@ on_operation_button_clicked            (GtkToggleButto
                 *      g_object_get_data (G_OBJECT (button), 
"display_string"));
                 */
                else {
-                       operation_string = g_strdup_printf ("%c", (int) 
g_object_get_data (
-                               G_OBJECT (button), "operation"));
+                       operation_string = g_strdup_printf ("%c", 
GPOINTER_TO_INT(g_object_get_data (
+                               G_OBJECT (button), "operation")));
                        ui_formula_entry_insert (operation_string);
                        g_free(operation_string);
                }
                return;
        }
        
-       current_token.operation = (int) g_object_get_data (G_OBJECT (button), 
"operation");
+       current_token.operation = GPOINTER_TO_INT(g_object_get_data (G_OBJECT 
(button), "operation"));
        /* current number, get it from the display! */
        current_token.number = display_result_get_double 
(current_status.number);
        current_token.func = NULL;
@@ -908,7 +908,7 @@ void user_functions_menu_handler (GtkMenuItem *menuite
        int                     index;
        s_flex_parser_result    result;
        
-       index = (int) user_data;
+       index = GPOINTER_TO_INT(user_data);
        result = compute_user_function (
                user_function[index].expression, user_function[index].variable,
                display_result_get());
-- 
Christian "naddy" Weisgerber                          [EMAIL PROTECTED]

Reply via email to