Re: httplib2 patch for python 2.6 support from maintainer

2008-12-24 Thread Federico G. Schwindt
On Wed, Dec 24, 2008 at 07:23:11PM +0100, Benoit Chesneau wrote: > On Wed, Dec 24, 2008 at 6:10 PM, Federico G. Schwindt > wrote: > > > do you mind to explain why you've added has_timeout()? > > if timeout is _GLOBAL_DEFAULT_TIMEOUT, you'll be setting it without > > effect, so why having a sep

Re: httplib2 patch for python 2.6 support from maintainer

2008-12-24 Thread Benoit Chesneau
On Wed, Dec 24, 2008 at 6:10 PM, Federico G. Schwindt wrote: > do you mind to explain why you've added has_timeout()? > if timeout is _GLOBAL_DEFAULT_TIMEOUT, you'll be setting it without > effect, so why having a separate function for basically a noop? the problem is that timeout isn't always

Re: httplib2 patch for python 2.6 support from maintainer

2008-12-24 Thread Federico G. Schwindt
On Mon, Dec 22, 2008 at 11:39:22PM +0100, Benoit Chesneau wrote: > Here is a patch to add support for python 2.6 in httplib2. I proposed > the patch mainstream, but no answer yet from the httplib2 author > (http://code.google.com/p/httplib2/issues/detail?id=39). This patch > fix deprecation warning

httplib2 patch for python 2.6 support from maintainer

2008-12-22 Thread Benoit Chesneau
Here is a patch to add support for python 2.6 in httplib2. I proposed the patch mainstream, but no answer yet from the httplib2 author (http://code.google.com/p/httplib2/issues/detail?id=39). This patch fix deprecation warning and timeout error in python 2.6. It pass tests like in python 2.5 . Her