Re: net/ii bus error

2016-06-06 Thread Ray Lai
Tested, works well. Okay by me. > On Jun 6, 2016, at 12:56 PM, Gleydson Soares wrote: > > > Sebastien Marie writes: >> >>> On Mon, Jun 06, 2016 at 06:15:40AM +0200, Sebastien Marie wrote: On Mon, Jun 06, 2016 at 12:50:02AM -0300, Gleydson Soares wrote: - add '# uses pledge()'

Re: net/ii bus error

2016-06-05 Thread Gleydson Soares
Sebastien Marie writes: > > On Mon, Jun 06, 2016 at 06:15:40AM +0200, Sebastien Marie wrote: > > On Mon, Jun 06, 2016 at 12:50:02AM -0300, Gleydson Soares wrote: > > > > > > - add '# uses pledge()' marker in Makefile (missing in previus) > > > - wrap pledge(2) in #ifdef __OpenBSD__ > > > > ok

Re: net/ii bus error

2016-06-05 Thread Sebastien Marie
On Mon, Jun 06, 2016 at 06:15:40AM +0200, Sebastien Marie wrote: > On Mon, Jun 06, 2016 at 12:50:02AM -0300, Gleydson Soares wrote: > > > > - add '# uses pledge()' marker in Makefile (missing in previus) > > - wrap pledge(2) in #ifdef __OpenBSD__ > > ok semarie@ whoops: finally not ok: there are

Re: net/ii bus error

2016-06-05 Thread Sebastien Marie
On Mon, Jun 06, 2016 at 12:50:02AM -0300, Gleydson Soares wrote: > > - add '# uses pledge()' marker in Makefile (missing in previus) > - wrap pledge(2) in #ifdef __OpenBSD__ ok semarie@ > Index: Makefile > === > RCS file: /cvs/ports

Re: net/ii bus error

2016-06-05 Thread Gleydson Soares
Hi, Gleydson Soares writes: > > Hi, > > Ray Lai writes: > > > > On Sun, 5 Jun 2016 21:41:54 +0800 > > Ray Lai wrote: > > > > > On Sun, 5 Jun 2016 14:10:25 +0200 > > > Sebastien Marie wrote: > > > > - does the patch maintained locally or by upstream ? if it is only > > > > locally, I

Re: net/ii bus error

2016-06-05 Thread Gleydson Soares
Hi, Ray Lai writes: > > On Sun, 5 Jun 2016 21:41:54 +0800 > Ray Lai wrote: > > > On Sun, 5 Jun 2016 14:10:25 +0200 > > Sebastien Marie wrote: > > > - does the patch maintained locally or by upstream ? if it is only > > > locally, I would kept it as simple as possible. > > > > > >

Re: net/ii bus error

2016-06-05 Thread Ray Lai
On Sun, 5 Jun 2016 21:41:54 +0800 Ray Lai wrote: > On Sun, 5 Jun 2016 14:10:25 +0200 > Sebastien Marie wrote: > > - does the patch maintained locally or by upstream ? if it is only > > locally, I would kept it as simple as possible. > > > > with only one pledge call, it is really

Re: net/ii bus error

2016-06-05 Thread Ray Lai
On Sun, 5 Jun 2016 14:10:25 +0200 Sebastien Marie wrote: > - does the patch maintained locally or by upstream ? if it is only > locally, I would kept it as simple as possible. > > with only one pledge call, it is really simple to understand what is > pledged and what it isn't. s

Re: net/ii bus error

2016-06-05 Thread Sebastien Marie
On Sun, Jun 05, 2016 at 06:57:32PM +0800, Ray Lai wrote: > On Sun, 5 Jun 2016 10:01:04 +0200 > Sebastien Marie wrote: > > > On Sun, Jun 05, 2016 at 03:18:52PM +0800, Ray Lai wrote: > > > I pledged your diff. > > > > some comments inlined. > > Fixed. > > I used 2 pledges, one before initializ

Re: net/ii bus error

2016-06-05 Thread Ray Lai
On Sun, 5 Jun 2016 10:01:04 +0200 Sebastien Marie wrote: > On Sun, Jun 05, 2016 at 03:18:52PM +0800, Ray Lai wrote: > > I pledged your diff. > > some comments inlined. Fixed. I used 2 pledges, one before initialization. Is that okay, or is it better to just have one pledge? Thanks for your

Re: net/ii bus error

2016-06-05 Thread Sebastien Marie
On Sun, Jun 05, 2016 at 03:18:52PM +0800, Ray Lai wrote: > I pledged your diff. some comments inlined. thanks. -- Sebastien Marie > Index: patches/patch-ii_c > === > RCS file: patches/patch-ii_c > diff -N patches/patch-ii_c > --- /

Re: net/ii bus error

2016-06-05 Thread Ray Lai
I pledged your diff. Index: Makefile === RCS file: /home/cvs/ports/net/ii/Makefile,v retrieving revision 1.13 diff -u -p -r1.13 Makefile --- Makefile21 May 2016 05:31:38 - 1.13 +++ Makefile5 Jun 2016 07:02:48 - @@

Re: net/ii bus error

2016-06-04 Thread Ray Lai
This fixes my crash, thanks! On Jun 5, 2016, at 2:58 AM, Gleydson Soares wrote: >> Looks like there's an use after freeing in main loop >> Attached diff should fix it. Could you try? >> Thanks, > > updated diff. (it was missing a bump) > > cvs server: Diffing . > Index: Makefile >

Re: net/ii bus error

2016-06-04 Thread Gleydson Soares
> Looks like there's an use after freeing in main loop > Attached diff should fix it. Could you try? > Thanks, updated diff. (it was missing a bump) cvs server: Diffing . Index: Makefile === RCS file: /cvs/ports/net/ii/Makefile,v ret

Re: net/ii bus error

2016-06-04 Thread Gleydson Soares
Hi Ray, Ray Lai writes: > > (terminal 1) > $ ii > > (terminal 2) > $ echo '/j #test123' >> ~/irc/irc.freenode.net/in > $ echo '/l #test123' >> ~/irc/irc.freenode.net/'#test123'/in > > (terminal 1) > Bus error (core dumped) > $ egdb ./ii ~/ii.core > GNU gdb (GDB) 7.11 > Copyright (C) 2016 Free

net/ii bus error

2016-06-04 Thread Ray Lai
(terminal 1) $ ii (terminal 2) $ echo '/j #test123' >> ~/irc/irc.freenode.net/in $ echo '/l #test123' >> ~/irc/irc.freenode.net/'#test123'/in (terminal 1) Bus error (core dumped) $ egdb ./ii ~/ii.core GNU gdb (GDB) 7.11 Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL ve