Re: audio/xmms: sndio plugin update to test

2012-09-06 Thread Alexandre Ratchov
Here's the final xmms diff; I got two test reports only, but I believe this is correct. ok? -- Alexandre Index: Makefile === RCS file: /cvs/ports/audio/xmms/Makefile,v retrieving revision 1.79 diff -u -p -r1.79 Makefile ---

Re: audio/xmms: sndio plugin update to test

2012-09-06 Thread Stuart Henderson
On 2012/09/06 09:02, Alexandre Ratchov wrote: Here's the final xmms diff; I got two test reports only, but I believe this is correct. ok? I don't normally use xmms (prefer aqualung) but thought I'd have a look, I tried quite hard to get the unpatched one to crash but only managed to get one

Re: audio/xmms: sndio plugin update to test

2012-09-05 Thread Brett
On Tue, 4 Sep 2012 20:08:52 -0400 Brad Smith b...@comstyle.com wrote: On Tue, Aug 28, 2012 at 01:34:40AM +0200, Alexandre Ratchov wrote: Thanks to all for the quick feedback. Below is a new diff; fixes hangs with certain buffer size and updates the unsupported format text. Brett, naddy

Re: audio/xmms: sndio plugin update to test

2012-09-05 Thread Christian Weisgerber
Brad Smith b...@comstyle.com wrote: Brett, naddy or any other xmms users? Still looking for some testing with the newer diff revision. The second diff works fine for me and I told ratchov@ so. I haven't seen the third version Brett mentions. -- Christian naddy Weisgerber

Re: audio/xmms: sndio plugin update to test

2012-09-04 Thread Brad Smith
On Tue, Aug 28, 2012 at 01:34:40AM +0200, Alexandre Ratchov wrote: Thanks to all for the quick feedback. Below is a new diff; fixes hangs with certain buffer size and updates the unsupported format text. Brett, naddy or any other xmms users? Still looking for some testing with the newer diff

Re: audio/xmms: sndio plugin update to test

2012-08-28 Thread Christian Weisgerber
Brett: Also on amd64-current, I've got xmms (with the second diff that Alexandre sent out), xmms-flac, xmms-mikmod, xmms-mp3, xmms-vorbis installed, but I got no playback with mp3s, oggs, or flacs. Is there some settings/configs you have changed from the default? No. I moved away my

Re: audio/xmms: sndio plugin update to test

2012-08-27 Thread Christian Weisgerber
Alexandre Ratchov a...@caoua.org wrote: This fixes threading bugs guenther found when we switched to rthreads. Most changes are copy paste from audacious. Basically, call any sio_* function with the mutex locked. But since we can't hold the mutex locked during blocking operations (the GUI

Re: audio/xmms: sndio plugin update to test

2012-08-27 Thread Alexandre Ratchov
Thanks to all for the quick feedback. Below is a new diff; fixes hangs with certain buffer size and updates the unsupported format text. -- Alexandre Index: Makefile === RCS file: /cvs/ports/audio/xmms/Makefile,v retrieving revision

Re: audio/xmms: sndio plugin update to test

2012-08-27 Thread Brett
The good news is that this fixes the problem guenther@ found. I can now play a directory full of MP3s just fine. Streaming works, too. As do FLAC files, after installing xmms-flac. -current/amd64 Also on amd64-current, I've got xmms (with the second diff that Alexandre sent out),

audio/xmms: sndio plugin update to test

2012-08-26 Thread Alexandre Ratchov
This fixes threading bugs guenther found when we switched to rthreads. Most changes are copy paste from audacious. Basically, call any sio_* function with the mutex locked. But since we can't hold the mutex locked during blocking operations (the GUI would block) use a simple event loop with

Re: audio/xmms: sndio plugin update to test

2012-08-26 Thread Brett
On Sun, 26 Aug 2012 21:48:52 +0200 Alexandre Ratchov a...@caoua.org wrote: This fixes threading bugs guenther found when we switched to rthreads. Most changes are copy paste from audacious. Basically, call any sio_* function with the mutex locked. But since we can't hold the mutex locked

Re: xmms sndio plugin update

2010-10-27 Thread Alexandre Ratchov
On Sat, Oct 23, 2010 at 02:03:35PM +0200, Thomas Pfaff wrote: ports@openbsd.org Here's a slightly revised diff (some style changes and more comments). It seems XMMS completely broke the Effect plugin system after they added support for multiple enabled effects. The only way to fix this

Re: xmms sndio plugin update

2010-10-27 Thread David Coppa
On Wed, Oct 27, 2010 at 2:27 PM, Alexandre Ratchov a...@caoua.org wrote: On Sat, Oct 23, 2010 at 02:03:35PM +0200, Thomas Pfaff wrote: ports@openbsd.org Here's a slightly revised diff (some style changes and more comments). It seems XMMS completely broke the Effect plugin system after they

Re: xmms sndio plugin update

2010-10-23 Thread Thomas Pfaff
ports@openbsd.org Here's a slightly revised diff (some style changes and more comments). It seems XMMS completely broke the Effect plugin system after they added support for multiple enabled effects. The only way to fix this seems to be to patch up XMMS but as far as I can tell, none of the

xmms sndio plugin update

2010-10-18 Thread Thomas Pfaff
Hi. Oscar Ross notified me that none of the effect plugins worked and sent me a diff (that I reworked a bit) to make them operational again. XMMS is a bitch to work with but the diff below fixes the problem for me, so please test this and let me know of any problems. Thank you. Index: Makefile