Re: Static analysis scan results

2018-12-02 Thread Viktor Dukhovni
On Sun, Dec 02, 2018 at 05:23:31PM -0500, Wietse Venema wrote: > Thanks for not posting the false positives. Yes, very much appreciated, I should have said the same. It is a rare pleasure to see a report where the required effort was put in to eliminate noisy distractions. Thanks again. --

Re: Static analysis scan results

2018-12-02 Thread Wietse Venema
Jaroslav Skarvada: > postfix-3.2.5/src/util/dict_random.c:112: leaked_storage: Variable "argv" > going out of scope leaks the storage it points to. > # 110| || ((argv = argv_splitq(saved_name, CHARS_COMMA_SP, > CHARS_BRACE)), > # 111| (argv->argc == 0))) > # 112|-> DICT_RAN

Re: Static analysis scan results

2018-12-02 Thread Viktor Dukhovni
On Sun, Dec 02, 2018 at 02:48:47PM -0500, Jaroslav Skarvada wrote: > src/posttls-finger/posttls-finger.c:1412: > # 1410| if (state->smtp == 0) { > # 1411| if (strncmp(dest, "unix:", 5) == 0) { > # 1412|-> connect_unix(state, dest + 5); > # 1413| if (!state->stream) >

Static analysis scan results

2018-12-02 Thread Jaroslav Skarvada
Hi, I got to Coverity static analysis scan report for postfix. Most of the errors were false positives, but two minor errors seems suspicious, that it could cause leaks, so sharing them for review. Unfortunately, it's result for postfix-3.2.5, but the same code is in the latest postfix - just the