Re: milter macro names (potential patch)''

2017-02-15 Thread Matthias Schneider
This breaks milter_macro_defaults lookups, which always require the form {name}. This would have been found immediately if the library had tests. Wietse I don't use the new milter_macro_defaults feature yet, so Viktors patch is ok for now. Hope you can find a good long term solution,

Re: milter macro names (potential patch)''

2017-02-14 Thread Wietse Venema
Viktor Dukhovni: > On Tue, Feb 14, 2017 at 09:43:25PM +0100, Matthias Schneider wrote: > > Hi Viktor, > > > > i applyed the patch and after connecting to port 25 i'll get: > > > > Yes, sorry, the original patch is buggy, it fails to initialize > "cname" for already canonical (enclosed in {}) mul

Re: milter macro names

2017-02-14 Thread A. Schulze
Am 14.02.2017 um 17:54 schrieb Matthias Schneider: > This broke our milter Hello, could you disclose the milter name and version? Maybe others could avoid some trouble... Andreas

Re: milter macro names (potential patch)

2017-02-14 Thread Viktor Dukhovni
> On Feb 14, 2017, at 4:06 PM, Matthias Schneider > wrote: > > This patch works like a charm! > Any chance to get this back into next stable release? That's a question for Wietse, he may want to solve this in a different way, or perhaps not at all (arguably your application should be able to d

Re: milter macro names (potential patch)

2017-02-14 Thread Matthias Schneider
Hi Viktor, this patch works like a charm! Any chance to get this back into next stable release? Best regards Matthias Schneider - Ursprüngliche Mail - Von: "Viktor Dukhovni" An: postfix-users@postfix.org Gesendet: Dienstag, 14. Februar 2017 21:54:44 Betreff: Re: milter m

Re: milter macro names (potential patch)

2017-02-14 Thread Viktor Dukhovni
On Tue, Feb 14, 2017 at 09:43:25PM +0100, Matthias Schneider wrote: > Hi Viktor, > > i applyed the patch and after connecting to port 25 i'll get: > Yes, sorry, the original patch is buggy, it fails to initialize "cname" for already canonical (enclosed in {}) multi-char names. Try this one inste

Re: milter macro names (potential patch)

2017-02-14 Thread Matthias Schneider
msg_info("%s: using default \"%s\"", myname, value); argv_add(argv, name, value, (char *) 0); } } myfree(saved_names); vstring_free(canon_buf); return (argv); } Thank you, Matthias Schneider - Ursprüngliche Mail --

Re: milter macro names (potential patch)

2017-02-14 Thread Viktor Dukhovni
On Tue, Feb 14, 2017 at 05:54:07PM +0100, Matthias Schneider wrote: > I just tried to upgrade our postfix instances from 2.11 to 3.1. This broke > our milter that is expecting macro with name "i" but we got "{i}". > Could we make this configurable? It may be simplest to revert to the original (br

milter macro names

2017-02-14 Thread Matthias Schneider
Hi, I just tried to upgrade our postfix instances from 2.11 to 3.1. This broke our milter that is expecting macro with name "i" but we got "{i}". Could we make this configurable? postfix 2.11: .b...b.rDRi.3vN6Xk4v7ZzDwHS.{rcpt_addr}.matthias.schneider@ postfix 3.1: 6ZH.6ZHkDR{i}.3vN6