Hi Joe, Thanks for the fix! For future reference, I found some guidance on the suggested way of collaborating via GitHub: https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution and https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork are really helpful. Apparently, it involved adding a remote for upstream, pulling from there, merging the upstream with the fork branch. I missed the last step.
The python http.server works a marvel, great tool :). Jan-Pieter Op wo 13 jul. 2022 om 23:55 schreef Joe Bogner <joebog...@gmail.com>: > On Tue, Jul 12, 2022 at 3:23 PM Jan-Pieter Jacobs < > janpieter.jac...@gmail.com> wrote: > > > Hi Joe, > > > > Apparently I indeed made a mistake in the NN example, I didn't duplicated > > the \ for on lines 317 and 339 of examples.js. This causes the intended \ > > to disappear in the editor and the example not to work, sorry for the > mess. > > A pull-request for 2 characters seemed a bit heavy handed, so I report it > > here, hoping you could fix it when you see fit. > > > > > No problem. I've fixed it > > > > Additionally, I didn't get what one is to do to continue contributing > once > > a pull-request is accepted, to update the fork used for the pull-request > > with the changes made upstream. I ended up in a situation where Github > > tells me my fork is 2 commits ahead and 2 behind, while I don't see the > > difference... > > Do you have any indications what the correct workflow is to contribute > > using pull-requests? Having a recommended workflow would likely be handy > > for other contributors, also for other repo's, like J addons. > > > > > I think you should just need to do a ```git pull``` to update your local > copy > > > > To avoid pushing untested code, how do you test the playground locally? I > > tried just opening index.html in Firefox, which shows the interface, but > > the terminal doesn't work (likely due to some cross-site restrictions of > > the browser, showing up in the developer tools log (Cross-Origin Request > > Blocked: The Same Origin Policy disallows reading the remote resource at > > file:///home/jpjacobs/Projects/J/j-playground/bin/html2/emj.data. > (Reason: > > CORS request not http).). I had hoped it would work, since the early J > > browser implementation you made few years back does work when opened > from a > > folder (I've used it for years from a downloaded copy with a few tweaks). > > > > Good question! I normally run it using a web server as (lightly) > documented here: https://github.com/jsoftware/j-playground#html... I use > ```python3 -m http.server``` > > I was curious to dig more and found this link... > > https://stackoverflow.com/questions/10752055/cross-origin-requests-are-only-supported-for-http-error-when-loading-a-local > > I had success launching my chrome as ```chrome.exe > --allow-file-access-from-files``` > and then opening up file:///C:/dev/j-playground/bin/html2/index.html works > without a web server. > ---------------------------------------------------------------------- > For information about J forums see http://www.jsoftware.com/forums.htm > ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
