Re: [prometheus-developers] Prometheus rules and runtime reload

2020-03-22 Thread Frederic Branczyk
I don’t know the exact setup of the helm chart, but generally those use cases are covered by the prometheus operator. The first by provisioning PrometheusRule objects in the application namespace and the second, Prometheus is simply automatically reloaded when the new rule appears in the

[prometheus-developers] Prometheus rules and runtime reload

2020-03-22 Thread EnthuDeveloper
Hello, I am trying helm charts(prometheus operator ) to install Prometheus and Alertmanager. Looking for some recommendations as to what the preferable options are for : 1. Reading alert rules generated from our application in form of a yaml file and loading them to container running Prometheus

Re: [prometheus-developers] Extending tsdb tests

2020-03-22 Thread Bartłomiej Płotka
Interesting idea. I think it's something to be considered by our explorations like modularize. For each change of exported package we could just trigger some jobs in Thanos and Cortex CI which will try to upgrade dep and run tests. But still, it will be pain to maintain in terms of interface

Re: [prometheus-developers] Extending tsdb tests

2020-03-22 Thread 'Matthias Rampke' via Prometheus Developers
I am a little concerned about "tests that are okay to fail" … especially since merging one PR with that means we have no signal for subsequent PRs. Meanwhile corthanos might adjust their usage, breaking older branches that don't even touch this (solvable with rebasing but adds additional round