Re: [prometheus-developers] Extending tsdb tests

2020-03-22 Thread 'Matthias Rampke' via Prometheus Developers
I am a little concerned about "tests that are okay to fail" … especially since merging one PR with that means we have no signal for subsequent PRs. Meanwhile corthanos might adjust their usage, breaking older branches that don't even touch this (solvable with rebasing but adds additional round

Re: [prometheus-developers] Prometheus Alert handle/resolve handling

2020-03-03 Thread 'Matthias Rampke' via Prometheus Developers
I think it helps to think about Alertmanager webhooks differently. Alertmanager does not notify about individual alerts but about *groups* of alerts. These groups come into being, the number of alert instances in them potentially changes over time. Subsequent webhooks about the same groups are

Re: [prometheus-developers] Checking if NFS is hanged or not using node_exporter.

2020-03-03 Thread 'Matthias Rampke' via Prometheus Developers
The trouble is that the only sure way to know if MFS hangs is to try and use it. For one, the node exporter is not a health prober per se, bur more importantly, when NFS does hang, this leaves a thread permanently stuck in an uninterruptible syscall. Very soon the exporter would run out of threads

Re: [prometheus-developers] Official Prometheus video playlist

2020-03-02 Thread 'Matthias Rampke' via Prometheus Developers
Do we have a somewhat up-to-date curated list of Prometheus-related talks / recordings that are already around? /MR On Sun, Mar 1, 2020 at 8:45 AM Julius Volz wrote: > I always wanted to create some YouTube videos covering certain topics, but > never did it yet because I have certain quality

Re: [prometheus-developers] [VOTE] New governance document

2020-02-20 Thread 'Matthias Rampke' via Prometheus Developers
Yes On Thu, 20 Feb 2020, 06:32 Julien Pivotto, wrote: > Yes > > - Original Message - > From: Richard Hartmann > To: Prometheus Developers > Sent: Wed, 19 Feb 2020 21:43:52 +0100 (CET) > Subject: [prometheus-developers] [VOTE] New governance document > > Dear all, > > I am hereby

Re: [prometheus-developers] Moving "official" JIRA Alertmanager integration (github.com/free/jiralert) to prometheus-community Organization.

2020-02-17 Thread 'Matthias Rampke' via Prometheus Developers
+1 given the prominence of "warning alert = ticket" in SRE lore, having a building block available for this in -community is a good thing. /MR On Sun, Feb 16, 2020 at 11:08 AM Bartłomiej Płotka wrote: > Hi, > > As per https://github.com/prometheus-community/community/issues/6 I would > like to

Re: [prometheus-developers] prometheus/prometheus Changelog Management

2020-02-14 Thread 'Matthias Rampke' via Prometheus Developers
How do I make it so there is no entry? On Fri, 14 Feb 2020, 18:07 Simon Pasquier, wrote: > Correct, the PR is in the promu repository (I've updated it just now > to address comments from Brian though it should have been done long > ago): > https://github.com/prometheus/promu/pull/170 > > Right

Re: [prometheus-developers] prometheus/prometheus Changelog Management

2020-02-14 Thread 'Matthias Rampke' via Prometheus Developers
The friction is real – DCO is not a submission quality issue but a roundtrip one. This would be even more difficult with wording. I agree that in *many* cases contributors can write the changelog entry; having the field in the PR template would encourage them to do so proactively. /MR On Fri,

Re: [prometheus-developers] prometheus/prometheus Changelog Management

2020-02-14 Thread 'Matthias Rampke' via Prometheus Developers
mit message for this! We can > definitely build some automation around this and it looks like such > workflow would be a huge improvement! > > Thanks Matthias. > > Kind Regards, > Bartek > > On Fri, 14 Feb 2020 at 13:02, 'Matthias Rampke' via Prometheus Develo

Re: [prometheus-developers] prometheus/prometheus Changelog Management

2020-02-14 Thread 'Matthias Rampke' via Prometheus Developers
In the exporters that I maintain I specifically ask contributors not to fill in the changelog. I want to keep a somewhat editorial voice there. I often rephrase changes to highlight what the change means for users, and usually provide extra remarks like upgrade instructions or deprecation notices.

Re: [prometheus-developers] How to delay de-duplication of alerts in AlertManager

2020-02-12 Thread 'Matthias Rampke' via Prometheus Developers
Hey, this is a new question, and not really development related. You'll more likely get an answer if you open a new thread on the prometheus-users mailing list. Thank you! Matthias On Tue, Feb 11, 2020 at 10:52 PM Dhiman Barman wrote: > Hi, > > We have the following metrics in our Prometheus