Re: [prometheus-developers] Protobuf support

2024-03-06 Thread Bjoern Rabenstein
Disclaimer: I'm not the expert for remote-write/-read, and only do a little with the protobuf stuff. But since you didn't get an answer in a week, I'm trying now. On 29.02.24 20:38, Clément Jean wrote: > > I finally go around to do this and the unit tests seem to be passing. You > can find what

Re: [prometheus-developers] Protobuf support

2024-02-29 Thread Clément Jean
Hey, I finally go around to do this and the unit tests seem to be passing. You can find what I did here: https://github.com/Clement-Jean/prometheus-move-to-proto. I still have few questions: - For the benchmarking, should I try running the benchmark on the current version of prometheus and the

Re: [prometheus-developers] Protobuf support

2023-10-22 Thread Bryan Boreham
> - why not moving to the official generated code? It seems it's the only stable one on the long term At least because nobody has put the work in to do the conversion and demonstrate it is no worse than today. I don't like the extra fields in generated structs, but I didn't measure the impact.

Re: [prometheus-developers] Protobuf support

2023-10-19 Thread Clément Jean
That actually sounds interesting to me! I have few questions though: - why not moving to the official generated code? It seems it's the only stable one on the long term - Is there a benchmark that I could run for prometheus using different plugins? - How can I test if my code changes didn't brea

Re: [prometheus-developers] Protobuf support

2023-10-18 Thread Bjoern Rabenstein
On 05.10.23 17:48, Clément Jean wrote: > I'm not entirely sure yet because I'm new to contributing to prometheus. If > there is any use cases that you guys already discussed around Protobuf, I'd > be happy to help. If you are really deep into protobuf, there is definitely one big and fat issue t

Re: [prometheus-developers] Protobuf support

2023-10-05 Thread Clément Jean
I'm not entirely sure yet because I'm new to contributing to prometheus. If there is any use cases that you guys already discussed around Protobuf, I'd be happy to help. On Wednesday, October 4, 2023 at 9:22:05 PM UTC+8 Bjoern Rabenstein wrote: > On 03.10.23 18:06, Clément Jean wrote: > > > >

Re: [prometheus-developers] Protobuf support

2023-10-04 Thread Bjoern Rabenstein
On 03.10.23 18:06, Clément Jean wrote: > > I met with Richard Hartmann at KubeCon Shanghai and he mentioned that the > team is interested in adding support for Protobuf. I'm here to see what I > can do to help. If you have any recommendation on how to get started, I'd > be happy to start contri

[prometheus-developers] Protobuf support

2023-10-03 Thread Clément Jean
Hey everyone, I met with Richard Hartmann at KubeCon Shanghai and he mentioned that the team is interested in adding support for Protobuf. I'm here to see what I can do to help. If you have any recommendation on how to get started, I'd be happy to start contributing. -- You received this mess