[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-25 Thread Matt Layher
Apologies for the delay, but YES to releasing now. On Saturday, April 25, 2020 at 6:55:10 AM UTC-4, Richard Hartmann wrote: > > Dear all, > > from the amount of people who hummed and by who hummed, or did not > hum, it is my understanding that we have reached consensus. > > > Thank you, >

[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-25 Thread Richard Hartmann
Dear all, from the amount of people who hummed and by who hummed, or did not hum, it is my understanding that we have reached consensus. Thank you, Richard PS: I agree that Julien's PR should make it into 1.0.0 proper. On Thu, Apr 23, 2020 at 1:40 PM Richard Hartmann wrote: > > Dear all, > >

[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread 'Goutham Veeramachaneni' via Prometheus Developers
Yes to release 1.0.0 as is. Lets not block on the security review. On Thursday, April 23, 2020 at 12:41:10 PM UTC+1, Richard Hartmann wrote: > > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Richard Hartmann
On Thu, Apr 23, 2020 at 2:43 PM Brian Brazil wrote: > Let's be careful here with the word experimental, as that means something > very specific in Prometheus terms. "experimental" means that we can make > breaking changes to the API across versions, but doesn't say anything about > how

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Brian Brazil
On Thu, 23 Apr 2020 at 12:53, Matthias Rampke wrote: > I agree, if we plan on releasing 1.0, have an RC, a security review for a > feature marked experimental doesn't need to hold things up. We should make > it clear when we consider TLS "ready for serious use" but that's for > another release.

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julius Volz
Agreed as well under these circumstances. On Thu, Apr 23, 2020 at 1:53 PM Matthias Rampke wrote: > I agree, if we plan on releasing 1.0, have an RC, a security review for a > feature marked experimental doesn't need to hold things up. We should make > it clear when we consider TLS "ready for

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Matthias Rampke
I agree, if we plan on releasing 1.0, have an RC, a security review for a feature marked experimental doesn't need to hold things up. We should make it clear when we consider TLS "ready for serious use" but that's for another release. /MR On Thu, Apr 23, 2020 at 11:47 AM Richard Hartmann <

[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Richard Hartmann
Yes On Thu, Apr 23, 2020 at 1:40 PM Richard Hartmann wrote: > > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features > experimental TLS support[2]. We are planning to