Re: Implement ShutdownProtobufLibrary().

2009-05-05 Thread jasonh
Sorry about the delay. Mostly looks good, just a few nits http://codereview.appspot.com/53053/diff/1/5 File google/protobuf/compiler/cpp/cpp_file.cc (right): http://codereview.appspot.com/53053/diff/1/5#newcode401 Line 401: Indent() for prettier generated code?

Re: Implement ShutdownProtobufLibrary().

2009-05-05 Thread Jason Hsueh
I believe the reasoning against this was for the case where the client doesn't care whether the memory is freed - in particular, if the shutdown is happening right before the process exits, then it would be doing a bunch of work to free memory that's going back to the OS anyway. Apparently this

Protocol Buffers RPC Server Implemention based on Mina(2.0-M5) and Protobuf(2.0.3)

2009-05-05 Thread Jun Tsai
Protocol Buffers RPC Server Implemention based on Mina(2.0-M5) and Protobuf(2.0.3). I had implemented a protocol buffers rpc server. http://github.com/bitiboy/fepss-rpc/tree/master. some idea from protobuf-socket-rpc. welcome feedback. --~--~-~--~~~---~--~~ You