[protobuf] Re: Best practice to parse extensions in c++

2010-07-20 Thread Johan Philips
On 21 jul, 00:22, Kenton Varda wrote: > IMO you should just include a tag field which contains some unique > identifier, as described in the docs you cite. So I just shouldn't have used your extensions mechanism but rather added to each message a unique id? Adding it now seems duplicate work si

Re: [protobuf] Recursion in .pbj file

2010-07-20 Thread Kenton Varda
What's pbj? Looks like a third-party protobuf implementation? If so you might want to contact the authors directly; I'm not sure if they read this list. On Tue, Jul 20, 2010 at 7:14 PM, bhupc wrote: > Hi all, > I am having trouble compiling this .pbj file: > > > > > message JSFieldValue > { >

[protobuf] Recursion in .pbj file

2010-07-20 Thread bhupc
Hi all, I am having trouble compiling this .pbj file: message JSFieldValue { optional string s_value = 1; optional int32 i_value = 2; optional JSMessage o_value = 3; } message JSField { required string name = 1; optional JSFieldValue value = 2; optional string prototype

[protobuf] Re: Issue 187 in protobuf: Command-line argument to override the "optimize_for" option

2010-07-20 Thread protobuf
Comment #10 on issue 187 by esho...@fusionio.com: Command-line argument to override the "optimize_for" option http://code.google.com/p/protobuf/issues/detail?id=187 Admittedly, my suggestion above does not handle imports and that makes it mostly unusable whether done in or outside of protoc

[protobuf] Re: Issue 81 in protobuf: Maven Protoc Plugin Code Review

2010-07-20 Thread protobuf
Comment #19 on issue 81 by ken...@google.com: Maven Protoc Plugin Code Review http://code.google.com/p/protobuf/issues/detail?id=81 Hi all, It seems clear that Greg doesn't have time to maintain this, and I can't maintain it either as I know nothing about Maven. Would someone like to fo

Re: [protobuf] Protobuf as generic marshalling layer

2010-07-20 Thread Kenton Varda
If you are writing a library, and the client of your library knows the exact type desired, then they should pass to you the class's default instance (C++ and Java; in Python they might as well pass the class itself). In C++ this is MyType::default_instance(), in Java MyType.getDefaultInstance().

Re: [protobuf] Protocol Buffers RPC design questions

2010-07-20 Thread Kenton Varda
On Thu, Jul 15, 2010 at 2:22 AM, Jamie McCrindle wrote: > Hi all, > > I've built a lightweight PB RPC implementation over HTTP which I'd > like to pad out with some more functionality but I have a few design > questions that I was hoping some of you folk in the group may be able > to help with: >

Re: [protobuf] Best practice to parse extensions in c++

2010-07-20 Thread Kenton Varda
IMO you should just include a tag field which contains some unique identifier, as described in the docs you cite. The reflection interface, if you want to use it, is documented here: http://code.google.com/apis/protocolbuffers/docs/reference/cpp/google.protobuf.message.html#Reflection On Fri, Ju

[protobuf] Re: Issue 187 in protobuf: Command-line argument to override the "optimize_for" option

2010-07-20 Thread protobuf
Comment #9 on issue 187 by ken...@google.com: Command-line argument to override the "optimize_for" option http://code.google.com/p/protobuf/issues/detail?id=187 I agree that protoc should provide something. I was merely pointing out that eshober's suggestion can trivially be implemented wi

[protobuf] Re: Issue 206 in protobuf: Python: possible to set invalid enum value

2010-07-20 Thread protobuf
Updates: Owner: pesho.petrov Comment #1 on issue 206 by ken...@google.com: Python: possible to set invalid enum value http://code.google.com/p/protobuf/issues/detail?id=206 Petar, I believe you were already planning to address this? Or did we decide that this change would break too

[protobuf] Re: Issue 187 in protobuf: Command-line argument to override the "optimize_for" option

2010-07-20 Thread protobuf
Comment #8 on issue 187 by dima: Command-line argument to override the "optimize_for" option http://code.google.com/p/protobuf/issues/detail?id=187 Now suppose foo.proto is imported by a few other .proto files... You'll have to modify each one of them, too. Every other compiler - gcc, jav

[protobuf] Re: Issue 203 in protobuf: mvn install ordering dependency

2010-07-20 Thread protobuf
Updates: Owner: gk5885 Comment #1 on issue 203 by ken...@google.com: mvn install ordering dependency http://code.google.com/p/protobuf/issues/detail?id=203 To clarify, the problem occurs only when the lite version is built *after* the full version without cleaning in between. Greg

[protobuf] Re: Issue 187 in protobuf: Command-line argument to override the "optimize_for" option

2010-07-20 Thread protobuf
Comment #7 on issue 187 by ken...@google.com: Command-line argument to override the "optimize_for" option http://code.google.com/p/protobuf/issues/detail?id=187 If you just want to append a string to the file, you can easily do that like: cp foo.proto foo2.proto echo 'option optimize_

Re: [protobuf] Re: FileDescriptorSet mania

2010-07-20 Thread Kenton Varda
On Tue, Jul 20, 2010 at 1:21 PM, Mark wrote: > Hi, > > Using the latest release of PB, I am able to generate the FileDescriptorSet > using protoc. my intent is to be able to parse incoming messages using the > DynamicMessage class. my understanding is that from the FileDescriptorSet, > I > can g

[protobuf] Re: FileDescriptorSet mania

2010-07-20 Thread Mark
Kenton Varda google.com> writes: > > > I'd be open to a class like: > > class DescriptorSetBuilder { >   // Adds the file and all its dependencies, if they have not been added already. >   // Returns this. >   public DescriptorSetBuilder add(FileDescriptor file); > > >   // Returns a FileD