Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread mailto . jonas
Thanks for the input Marc! I cannot find the thread you refer to. Was it developers from Google who gave you the answer? The groups alternative would really fix my problem. It is a pity that it is deprecated and that the same mechanism cannot be used for submessages! Hope for a response from

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread Oliver Jowett
On Wed, May 15, 2013 at 11:16 AM, mailto.jo...@gmail.com wrote: I think it is more of a bug in the protoc implementation that it fail's to parse such a message. Do you have some test code to share? (I got as far as eyeballing the C++ implementation and it looks OK at a first glance) Oliver

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread Oliver Jowett
On Wed, May 15, 2013 at 12:02 PM, Oliver Jowett oliver.jow...@gmail.comwrote: On Wed, May 15, 2013 at 11:16 AM, mailto.jo...@gmail.com wrote: I think it is more of a bug in the protoc implementation that it fail's to parse such a message. Do you have some test code to share? (I got as

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread Marc Gravell
To be explicit - I didn't say that any would *fail* to parse it - I simply said that it was not tested and not guaranteed. It is arguably a shame that the specification is ambiguous - it would be nice if it was explicitly either permitted or not. An interesting side-effect of this is that it

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread Feng Xiao
On Wed, May 15, 2013 at 3:16 AM, mailto.jo...@gmail.com wrote: Thanks for the input Marc! I cannot find the thread you refer to. Was it developers from Google who gave you the answer? The groups alternative would really fix my problem. It is a pity that it is deprecated and that the same

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread Marc Gravell
So far I haven't seen such data showing that prefixing a fixed-size length is a performance gain. That depends on the implementation ;) For implementations that know the lengths of data in advance (or can compute it cheaply by summing things that *do* know their own lengths), it probably isn't

Re: [protobuf] Performance aspect of submessage serialization

2013-05-15 Thread mailto . jonas
Hi all, Thanks for all input! I was about to post my serialization code when I realized that it contained an bug, rendering a size value that was correct size + 1. I have corrected the bug and now protoc deserializes the message without any warnings. All in all, without the bug, I would not

[protobuf] maven protocolBuffers plugin: unable to find imported .proto files

2013-05-15 Thread Safi Ali
Hi, I am using maven-protoc-plugin version 0.3.1 to compile my protoc definations. Protoc version is 2.5.0. I am having trouble adding the --proto_path in my maven protoc plugin configuration (in pom.xml). I have a protoc file (say A.protoc) which imports another protoc file (say B.protoc)

[protobuf] PATCH: Leading comments droppped when using --descriptor_set_out

2013-05-15 Thread Justin Bailey
Greetings! The protoc compiler will write a FileDescriptorProto protocol buffer describing its input files when given the --descriptor_set_out flag. If --include_source_info is also given, then comments (and other information) for each element will also be included. However, any comments at