[protobuf] Re: Issue 637 in protobuf: Patch for /trunk/src/google/protobuf/stubs/once.cc

2014-08-21 Thread protobuf
Updates: Status: Fixed Owner: jie...@google.com Labels: FixedIn-2.6.0 Comment #3 on issue 637 by jie...@google.com: Patch for /trunk/src/google/protobuf/stubs/once.cc https://code.google.com/p/protobuf/issues/detail?id=637 fixed by https://codereview.appspot.com/13074

[protobuf] Re: Issue 663 in protobuf: Undefined behavior while running unit tests

2014-08-21 Thread protobuf
Updates: Owner: jie...@google.com Comment #1 on issue 663 by jie...@google.com: Undefined behavior while running unit tests https://code.google.com/p/protobuf/issues/detail?id=663 Yes our implementation used this undefined behavior. Line 1103 -static_cast(value); tries to cast an ui

[protobuf] Re: Issue 488 in protobuf: powerpc-linux cross compilation not compiling anymore

2014-08-21 Thread protobuf
Comment #9 on issue 488 by robert.e...@gmail.com: powerpc-linux cross compilation not compiling anymore https://code.google.com/p/protobuf/issues/detail?id=488 https://codereview.appspot.com/129490043/ is based on Stanislav's patch, and is based on the patch we used in the Debian package of

Re: [protobuf] 2.6.0 release candidate

2014-08-21 Thread Robert Edmonds
'Feng Xiao' via Protocol Buffers wrote: > Can you help to do this? We'll probably need some changes to the patch but > as we can't test it in the relevant platforms the code review is better to > be initiated by someone who can make the change and test the change. > > It's very simple to create su

Re: [protobuf] Re: 2.6.0 release candidate

2014-08-21 Thread 'Jie Luo' via Protocol Buffers
Thank you Simon. I've add stl_util.h to nobase_include_HEADERS by https://code.google.com/p/protobuf/source/detail?r=574 Thanks, Jie 2014-08-21 9:54 GMT-07:00 Simon Newton : > > > > On Tuesday, August 19, 2014 1:39:28 PM UTC-7, Jie Luo wrote: >> >> Hi all, >> >> I have uploaded the release candi

[protobuf] Issue 663 in protobuf: Undefined behavior while running unit tests

2014-08-21 Thread protobuf
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 663 by robert.e...@gmail.com: Undefined behavior while running unit tests http://code.google.com/p/protobuf/issues/detail?id=663 Hello, When compiling protobuf 2.6.0-rc1 with gcc 4.9's undefined behavior detector, I get

[protobuf] Re: Issue 308 in protobuf: unresolved external symbol kEmptyString when linking protobuf as a dll.

2014-08-21 Thread protobuf
Comment #13 on issue 308 by jarek2ch...@gmail.com: unresolved external symbol kEmptyString when linking protobuf as a dll. http://code.google.com/p/protobuf/issues/detail?id=308 hi, i've sloved this issue by modyfing files enerated_message_util.h/cc adding decoration LIBPROTOBUF_EXPORT: doub

Re: [protobuf] 2.6.0 release candidate

2014-08-21 Thread Simon Newton
I get a build failures on Mac OS X 10.9: $ g++ --version Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) Target: x86_64-apple-darwin13.3.0 Thread model: posix I ge

Re: [protobuf] 2.6.0 release candidate

2014-08-21 Thread Simon Newton
On Thu, Aug 21, 2014 at 8:49 AM, Simon Newton wrote: > I get a build failures on Mac OS X 10.9: Sorry please ignore that, I was building the wrong RC. Simon > $ g++ --version > Configured with: > --prefix=/Applications/Xcode.app/Contents/Developer/usr > --with-gxx-include-dir=/usr/include/c++/

[protobuf] Re: 2.6.0 release candidate

2014-08-21 Thread Simon Newton
On Tuesday, August 19, 2014 1:39:28 PM UTC-7, Jie Luo wrote: > > Hi all, > > I have uploaded the release candidate of protobuf-2.6.0 > (protobuf-2.6.0rc1) here: > > https://protobuf.googlecode.com/svn/rc/ > > The RC1 has been tested on Linux, Mac, Cygwin, MinGW and MSVC (2010, > 2013). > >

[protobuf] 2.6.0rc1 fails to build on mac 10.9

2014-08-21 Thread Simon Newton
$ g++ --version Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) Target: x86_64-apple-darwin13.3.0 Thread model: posix I get the same errors when I use clang++ Er