Re: [protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-10 Thread Brad Larson
hat a better fix might be. However I consulted with a coworker and we came up with this: https://github.com/google/protobuf/pull/3480. It does solve my problem, but I'm unable to test on the wide variety of hardware platforms supported by GPB. > > On Wed, Aug 9, 2017 at 8:27 AM,

[protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-09 Thread Brad Larson
On Monday, August 7, 2017 at 1:13:46 PM UTC-5, Brad Larson wrote: > > Hello, I'm getting a compiler error when using GCC to target ARM > platforms. I've patched this locally, but would like to upstream my patch > and am not sure on the best generally-acceptable solution. &g

[protobuf] Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-07 Thread Brad Larson
Hello, I'm getting a compiler error when using GCC to target ARM platforms. I've patched this locally, but would like to upstream my patch and am not sure on the best generally-acceptable solution. src/google/protobuf/io/coded_stream.h: In static member function 'static bool

Re: [protobuf] Contribution Guide?

2017-07-17 Thread Brad Larson
me! :) Thanks again, Brad > > On Fri, Jul 14, 2017 at 10:14 AM, Brad Larson <bkla...@gmail.com > > wrote: > >> Hi all! I'm curious if there is a contribution guide for protobuf, or >> anything I should be doing to help get my patch merged. It is very small &g

[protobuf] Contribution Guide?

2017-07-14 Thread Brad Larson
Hi all! I'm curious if there is a contribution guide for protobuf, or anything I should be doing to help get my patch merged. It is very small and fixes a build error in our (warning-aggressive) environment at $DAYJOB. I've created an issue - https://github.com/google/protobuf/issues/3356 and

Re: [protobuf] Compiling protobuf with GOOGLE_PROTOBUF_NO_THREAD_SAFETY macro

2017-07-07 Thread Brad Larson
On Tuesday, July 19, 2016 at 10:15:29 AM UTC-5, Igor Gatis wrote: > > I'm using -DGOOGLE_PROTOBUF_NO_THREAD_SAFETY but I'm hitting the following > errors: > > "src/google/protobuf/stubs/atomic_sequence_num.h", line 43: Error: #20: > identifier "AtomicWord" is undefined > AtomicWord