Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2023-02-04 Thread Marc Gravell
That is ... contextual, though; an unexpected sub-message can still, depending on the implementation, be round-tripped and potentially even inspected via reflection. It won't usually *break* code, just like adding any new field. It really depends how strict you're being in you'd definitions of

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2023-02-04 Thread Robert Yokota
Hi Komal, Forward compatibility is broken as older consumers won't understand the new message. Regards, Robert On Fri, Feb 3, 2023 at 8:50 AM Komal Kamble wrote: > Hello Robert, > > Could you please elaborate on reason of having check for message_removed? > Adding new message doesn’t mean

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2023-02-03 Thread Komal Kamble
Hello Robert,Could you please elaborate on reason of having check for message_removed? Adding new message doesn’t mean compatibility is lost. Sent from my iPhoneOn 04-Dec-2022, at 9:41 AM, Robert Yokota wrote:Hi,I believe this is coming from the Confluent compatibility checker.  (I work for

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-12-04 Thread Robert Yokota
Hi, I believe this is coming from the Confluent compatibility checker. (I work for Confluent.) A forward compatibility check is just a backward compatibility check with the arguments reversed. Since removing a message is not backward compatible, adding a message is not forward compatible.

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-12-04 Thread 'Adam Cozzette' via Protocol Buffers
I don't think we maintain any code that returns that kind of error. Do you know where that error is coming from? Is it from some external protobuf compatibility checker? On Thu, Dec 1, 2022 at 4:21 AM Komal Kamble wrote: > > Hello Adam Cozzette, > We are getting Found incompatibility change

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-12-01 Thread Komal Kamble
Hello Adam Cozzette, We are getting Found incompatibility change error of type MESSAGE_REMOVED. > On 02-Nov-2022, at 11:41 PM, Adam Cozzette wrote: > >  > Adding more message types to the proto file is fine and has no compatibility > issues. Can you say more about the error you're getting?

Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-11-02 Thread 'Adam Cozzette' via Protocol Buffers
Adding more message types to the proto file is fine and has no compatibility issues. Can you say more about the error you're getting? On Wed, Nov 2, 2022 at 7:03 AM Komal Kamble wrote: > Hello ProtocolBufferSupport team, > > If I have a proto file with multiple sub-message types defined and If

[protobuf] Compatibility error on adding sub message type in existing proto file

2022-11-02 Thread Komal Kamble
Hello ProtocolBufferSupport team, If I have a proto file with multiple sub-message types defined and If I want to add more sub-message types in the same file I am getting BACKWARD and FORWARD compatibility errors. I am using com.github.os72:protoc-jar-maven-plugin:3.11.4 plugin in java module