Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Committed as rev 228. Thanks. On Mon, Sep 14, 2009 at 7:46 PM, Oliver Jowett wrote: > > Kenton Varda wrote: > > Can you review the diff, too? At Google we have a policy of reviewing > > all changes. Just tell me if it looks OK to you, or if there's anything > > you'd recommend changing (probab

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Kenton Varda wrote: > Can you review the diff, too? At Google we have a policy of reviewing > all changes. Just tell me if it looks OK to you, or if there's anything > you'd recommend changing (probably not since it's quite short). I looked at the diff and it seemed ok, but I'm no autoconf expe

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Can you review the diff, too? At Google we have a policy of reviewing all changes. Just tell me if it looks OK to you, or if there's anything you'd recommend changing (probably not since it's quite short). On Mon, Sep 14, 2009 at 5:30 PM, Oliver Jowett wrote: > Kenton Varda wrote: > > I expande

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Kenton Varda wrote: > I expanded on your patch a bit. Can you take a look? > > http://codereview.appspot.com/117047 I tried the updated patch on my system that has an old zlib, and it appears to work correctly (zlib support is disabled) -O --~--~-~--~~~---~--~~

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

I expanded on your patch a bit. Can you take a look? http://codereview.appspot.com/117047 On Fri, Aug 28, 2009 at 10:24 AM, Kenton Varda wrote: > I'm planning to submit this when I get a free moment (it's been a very busy > week). In the meantime, have you signed the CLA? > http://code.google.

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

I'm planning to submit this when I get a free moment (it's been a very busy week). In the meantime, have you signed the CLA? http://code.google.com/legal/individual-cla-v1.0.html -- If you own copyright on this patch. http://code.google.com/

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Kenton Varda wrote: > Run configure --without-zlib to disable zlib support. Alternatively, > fix it and send me a patch. :) I took a look at fixing it in gzip_stream.{cc,h} (conditionally removing GZIP format so you'd get compile errors if you tried to use that on a system with an old zlib), but

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Kenton Varda wrote: > (Is it just the gzip/zlib tests that are broken? Nothing else in the > library should depend on the zlib stuff.) I think so. Everything passed when I configured --without-zlib -O --~--~-~--~~~---~--~~ You received this message because you

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

(Is it just the gzip/zlib tests that are broken? Nothing else in the library should depend on the zlib stuff.) On Sat, Aug 22, 2009 at 11:13 AM, Kenton Varda wrote: > Run configure --without-zlib to disable zlib support. Alternatively, fix > it and send me a patch. :) > > > On Fri, Aug 21, 20

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Run configure --without-zlib to disable zlib support. Alternatively, fix it and send me a patch. :) On Fri, Aug 21, 2009 at 8:44 PM, Oliver Jowett wrote: > > Oliver Jowett wrote: > > > The tests start failing here: > > > >> [--] 14 tests from IoTest > >> [ RUN ] IoTest.ArrayIo > >>

Re: 2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Oliver Jowett wrote: > The tests start failing here: > >> [--] 14 tests from IoTest >> [ RUN ] IoTest.ArrayIo >> [ OK ] IoTest.ArrayIo (4 ms) >> [ RUN ] IoTest.GzipIo >> google/protobuf/io/zero_copy_stream_unittest.cc:194: Failure >> Value of: WriteToOutput(output, str.c_

2.2.0 "make check" failures on Solaris 10 sparc32 (problems with zlib?)

Environment: protobuf 2.2.0 $ uname -a SunOS arson 5.10 Generic_118833-23 sun4u sparc SUNW,Sun-Fire-280R $ g++ -v Reading specs from /usr/local/lib/gcc/sparc-sun-solaris2.10/3.4.6/specs Configured with: ../configure --with-as=/usr/ccs/bin/as --with-ld=/usr/ccs/bin/ld --enable-shared --enable-lan