Re: missing parseFrom(...) variants in generate Java code; and how to build your own parseFrom() equivalent

2009-08-19 Thread Kenton Varda
Feel free to send a patch. It would be nice if we could also move the meat of all the parseFrom methods into AbstractMessageLite -- as protected static methods that take the message default instance as the first parameter -- so that the generated code can be as simple as possible. I'm worried that

Re: missing parseFrom(...) variants in generate Java code; and how to build your own parseFrom() equivalent

2009-08-19 Thread Oliver Jowett
Kenton Varda wrote: > On Tue, Aug 18, 2009 at 6:55 PM, Oliver Jowett > wrote: > > > Hi > > Using 2.2.0, the compiler doesn't seem to be generating Java code for > the parseFrom(byte[],int,int) and > parseFrom(byte[],int,int,ExtensionRegistryLite)

Re: missing parseFrom(...) variants in generate Java code; and how to build your own parseFrom() equivalent

2009-08-19 Thread Kenton Varda
On Tue, Aug 18, 2009 at 6:55 PM, Oliver Jowett wrote: > > Hi > > Using 2.2.0, the compiler doesn't seem to be generating Java code for > the parseFrom(byte[],int,int) and > parseFrom(byte[],int,int,ExtensionRegistryLite) static methods. Did it ever generate those methods? I don't remember if it

missing parseFrom(...) variants in generate Java code; and how to build your own parseFrom() equivalent

2009-08-18 Thread Oliver Jowett
Hi Using 2.2.0, the compiler doesn't seem to be generating Java code for the parseFrom(byte[],int,int) and parseFrom(byte[],int,int,ExtensionRegistryLite) static methods. The other variants e.g. parseFrom(byte[]) are present. Is this deliberate, or just an oversight? Also, it seems a bit awkwa