[jira] [Commented] (PROTON-334) SASL Implementation for Proton C

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504348#comment-14504348 ] ASF GitHub Bot commented on PROTON-334: --- Github user dcristoloveanu commented on the

[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech

2015-04-20 Thread dcristoloveanu
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/19#issuecomment-94641331 I’ve removed the SASL client mechanism setter as I think PROTON-334 should do when it comes online. And if it does not we can always bring this back in anoth

[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech

2015-04-20 Thread dcristoloveanu
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/19#issuecomment-94636318 I had a look at PROTON-334 and I'll remove the SASL API from my pull request, since it seems PROTON-334 should allow the case we want and like you said the API

[jira] [Commented] (PROTON-334) SASL Implementation for Proton C

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504317#comment-14504317 ] ASF GitHub Bot commented on PROTON-334: --- Github user dcristoloveanu commented on the

Re: Messenger race condition on Android?

2015-04-20 Thread Adam Wynne
Hi Rafael, My answers to your questions are below... On Fri, Apr 17, 2015 at 8:33 AM Rafael Schloming-3 [via Qpid] < ml-node+s2158936n7623117...@n2.nabble.com> wrote: > On Fri, Apr 17, 2015 at 8:09 AM, Adam Wynne <[hidden email] > > wrote: >

[jira] [Commented] (PROTON-849) [proton-j] TransportLink state is never discarded

2015-04-20 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503472#comment-14503472 ] Robbie Gemmell commented on PROTON-849: --- Proposed some changes in a shared pull requ

[jira] [Commented] (PROTON-853) [proton-j] the transport emitted a new link attach for a link in the process of being detached

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503442#comment-14503442 ] ASF GitHub Bot commented on PROTON-853: --- Github user gemmellr commented on the pull

[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...

2015-04-20 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/21#issuecomment-94542644 @rhs can you take a look? @dnwe can you also take a look to confirm if the changes work for you, e.g. handles any tests you have elsewhere based on needing the earli

[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...

2015-04-20 Thread gemmellr
GitHub user gemmellr opened a pull request: https://github.com/apache/qpid-proton/pull/21 PROTON-853: stop erroneous attach being sent The changes for PROTON 154 commit 7d3063e7c488c97b9bad61e862d54b2b11dbc3d5 in 0.9 lead to situations where the transport will decide to send a new A

[jira] [Commented] (PROTON-853) [proton-j] the transport emitted a new link attach for a link in the process of being detached

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503431#comment-14503431 ] ASF GitHub Bot commented on PROTON-853: --- GitHub user gemmellr opened a pull request:

[GitHub] qpid-proton pull request: PROTON-848-and-849: stop leaking the tra...

2015-04-20 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/20#issuecomment-94533325 @rhs can you take a look please? Mainly at the channel/handle process updates, the actual leak prevention wasnt that interesting in the end. --- If your project is

[jira] [Commented] (PROTON-848) [proton-j] TransportSession state is never discarded

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503380#comment-14503380 ] ASF GitHub Bot commented on PROTON-848: --- Github user gemmellr commented on the pull

[jira] [Commented] (PROTON-848) [proton-j] TransportSession state is never discarded

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503375#comment-14503375 ] ASF GitHub Bot commented on PROTON-848: --- GitHub user gemmellr opened a pull request:

[GitHub] qpid-proton pull request: PROTON-848-and-849: stop leaking the tra...

2015-04-20 Thread gemmellr
GitHub user gemmellr opened a pull request: https://github.com/apache/qpid-proton/pull/20 PROTON-848-and-849: stop leaking the transport state Stops leaking the transport state by removing the maps storing the TransportSession or TransportLink objects, instead using the references s

[jira] [Resolved] (PROTON-854) [proton-j] ConnectionImpl retains all created Sessions until the Connection is freed

2015-04-20 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-854. --- Resolution: Fixed Fix Version/s: 0.10 Assignee: Robbie Gemmell > [proton-j] Co

[jira] [Commented] (PROTON-854) [proton-j] ConnectionImpl retains all created Sessions until the Connection is freed

2015-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503316#comment-14503316 ] ASF subversion and git services commented on PROTON-854: Commit 1e

[jira] [Commented] (PROTON-490) [proton-c] Python binding fails to link with Python 3 libraries

2015-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503152#comment-14503152 ] ASF subversion and git services commented on PROTON-490: Commit 81

[jira] [Commented] (PROTON-334) SASL Implementation for Proton C

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502714#comment-14502714 ] ASF GitHub Bot commented on PROTON-334: --- Github user rhs commented on the pull reque

[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech

2015-04-20 Thread rhs
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/19#issuecomment-94438477 @astitcher: do you want to wait until PROTON-334 lands to pull this in given the conflict you mention? --- If your project is set up for it, you can reply to this email

[jira] [Commented] (PROTON-334) SASL Implementation for Proton C

2015-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502710#comment-14502710 ] ASF GitHub Bot commented on PROTON-334: --- Github user rhs commented on the pull reque

[GitHub] qpid-proton pull request: PROTON-334: SASL Implementation for Prot...

2015-04-20 Thread rhs
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/17#issuecomment-94437344 Looks good to me, assuming all the tests pass and what not, I'm +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub