Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/45#issuecomment-120549130
Thanks, appreciate your help with the review!
/Dan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dcristoloveanu closed the pull request at:
https://github.com/apache/qpid-proton/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/45
-Fix 2 Code Analysis warnings in iocp.c and a realloc leak
-Fix one realloc leak and the fact that the realloc result was not checked.
This rippled through codec.c as more functions
Github user dcristoloveanu closed the pull request at:
https://github.com/apache/qpid-proton/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/43
-Fix 2 Code Analysis warnings and a realloc failure
-Fix 2 Code Analysis warnings in iocp.c
-Fix one realloc leak and the fact that the realloc result was not checked.
This rippled
Github user dcristoloveanu closed the pull request at:
https://github.com/apache/qpid-proton/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/39#issuecomment-116826581
Hi Andrew,
Thanks for the review, it's much appreciated.
There are several good points here that deserve a more in depth discussion,
so I
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/39#issuecomment-114940533
Ping ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/39
Fix 2 Code Analysis warnings and a realloc leak/result not checked
-Fix 2 Code Analysis warnings in iocp.c
-Fix one realloc leak and the fact that the realloc result was not checked
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-100987919
@dnwe Sorry about that, I updated the branch to have only on commit.
Thanks,
/Dan
---
If your project is set up for it, you can reply to this
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-100291491
@dnwe
1.Sure, updated
2.Changed to 512.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/27#issuecomment-100289485
I couldn't agree more. Actually all calls should have their result checked.
After all malloc/realloc are not more important than pb_buffer and al
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-99319844
Friendly ping ...
Thanks,
/Dan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/27#issuecomment-99319790
Friendly ping ...
Thanks,
/Dan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/27
Add some NULL checks and fix some realloc leaks
Along the lines of PROTON-727, added NULL checks for some malloc/realloc
calls that were either ignoring the result or leaking in the case
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/25
Initial transport frame size 256 bytes
In order to reduce RAM footprint on rather simple scenarios on small
devices the initial transport frame size could be lowered to 256, since the
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/24
Fix none_sasl.c to use pn_strdup instead of strdup
(PROTON-870) none_sasl.c should use pn_strdup.
none_sasl.c uses strdup, but strdup is not part of C99 and subsequently
does
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/19#issuecomment-95988615
I think this can be merged in now, unless there's anything else that you
think needs addressing.
Thanks!
/Dan
---
If your project is set u
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/19#issuecomment-94899556
I'll take a look at PROTON-334 and see if we need anything extra. If so,
I'll create another pull request.
Could we merge in this pull req
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/19#issuecomment-94641331
Iâve removed the SASL client mechanism setter as I think PROTON-334
should do when it comes online. And if it does not we can always bring this
back in
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/19#issuecomment-94636318
I had a look at PROTON-334 and I'll remove the SASL API from my pull
request, since it seems PROTON-334 should allow the case we want and like you
sai
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/19
Mbed minor changes and sasl mech
This are 2 minor changes in order to be able to:
- Compile on an Arm CC compiler and more specifically compile in mbed.org's
environment. Thes
22 matches
Mail list logo
