[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-07-01 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-07-01 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/37#issuecomment-117609566 This was merged by @rhs as cd42324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-16 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/37#issuecomment-112419828 (Not sure what is happening with the Travis CI build - as I can't reproduce the test case failure if I pull the reactor branch and build locally) --- If your proje

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-15 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/37 PROTON-881: Graceful handling of runtime exceptions thrown within han… …dlers When a runtime (unchecked) exceptions is thrown within a handler, the reactor now catches it and rethr

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-03 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-03 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/34#issuecomment-108472809 No problem. I'll re-work and submit another PR based around HandlerException being unchecked. --- If your project is set up for it, you can reply to this email an

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-03 Thread rhs
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/34#issuecomment-108444308 Hi Preston, sorry to take so long to look at this. My impulse here would be to avoid using a checked exception for HandlerException. I generally follow the advic

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-05-25 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/34 PROTON-881: Graceful handling of runtime exceptions thrown within han… Adds support for more gracefully handling runtime exceptions thrown from within a handler. When a runtime (unch