[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-05-06 Thread rhs
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/26#issuecomment-99432258 Looks good to me. On the struct initialization stuff, it might be worth seeing if we can make gcc turn those into errors if it causes problems on other compilers. ---

[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-04-29 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/26 proton-c: minor code fixes Prevent pn_data_vfill from peeking at memory outside the intended bounds and fix a few minor -Wextra warnings about incomplete struct initialisation You can merge this

[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-04-29 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/26#issuecomment-97600613 ![build passing](https://travis-ci.org/dnwe/qpid-proton.svg) https://travis-ci.org/dnwe/qpid-proton/builds/60601702 --- If your project is set up for it, you