[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880309#comment-13880309
]
Chuck Rolke commented on PROTON-488:
I never let cmake decide which compiler to use. E
[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883301#comment-13883301
]
Fraser Adams commented on PROTON-488:
-
Hey Cliff,
For info my JavaScript port of Proto
[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883314#comment-13883314
]
Fraser Adams commented on PROTON-488:
-
Oh to be clear
either "struct in and out", or "
[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883328#comment-13883328
]
Fraser Adams commented on PROTON-488:
-
For info I managed to pull out the bits that we
[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883472#comment-13883472
]
Fraser Adams commented on PROTON-488:
-
Hey Cliff,
Re "can you test if the review board
[
https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925863#comment-13925863
]
ASF subversion and git services commented on PROTON-488:
Commit 15
I can reproduce the problem even when using cmake as recommended.
The problem is proton's fast and loose use of binary data in the
codec. The assumption that a struct will be placed on the stack a
certain way falls apart in 64bit Visual Studio, so that it is no
longer OK to use either a single ar
Thanks for the Javascript related info.
Fraser: can you test if the review board patch (with the struct "in
and out" strategy) works in your case with the unhacked llvm setup?
If that works then I'll go ahead and check it in.
If it fails, please try the first patch. If that works, we will just
h
Hi, me again Cliff.
I've only had time to recheck this against my test case, which is
representative of what I see for real.
Doing:
int pn_data_vfill2(const char *fmt, va_list ap)
{
// Process the PROPERTIES constant - this seems OK
uint64_t prop = va_arg(ap, uint64_t);
printf("prop =
Well thanks for all that. I'll certainly take another look and report
back before committing anything. Giving a compiler family indigestion
is certainly to be avoided.
Cliff
On Tue, Jan 28, 2014 at 11:29 AM, Fraser Adams
wrote:
> Hi, me again Cliff.
> I've only had time to recheck this against
Hi again Cliff,
Have you made any progress on this?
Cheers,
Frase
On 30/01/14 02:31, Cliff Jansen wrote:
Well thanks for all that. I'll certainly take another look and report
back before committing anything. Giving a compiler family indigestion
is certainly to be avoided.
Cliff
On Tue, Jan 2
Sorry for the delay.
I played a bit with emcripten to see if there was some
misunderstanding going on, but it seems pretty clear that clang knows
exactly what is being passed in via the va_arg call and just plain
refuses to deal with a struct (at least for some architectures).
Consequently the o
Hi Cliff,
FYI I've just this minute merged all the latest updates to proton-c onto
the branch I'm using for the JavaScript bindings and have rebuilt
everything, the changes that you've done for this Jira work beautifully
for me too!!! Many thanks, you're a star.
Cheers,
Frase
On 28/02/14 08:
13 matches
Mail list logo
