[ https://issues.apache.org/jira/browse/PROTON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887869#comment-13887869 ]
Robbie Gemmell commented on PROTON-503: --------------------------------------- That seemed to do the trick, the build now fails es expected (output below). I have split the actual test failure out to PROTON-504 so this one can be marked resolved. Totals: 266 tests, 219 passed, 21 skipped, 25 ignored, 1 failed Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 43.633 sec <<< FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 43.633 sec <<< FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File "C:\workspace\proton\tests\python\proton-test", line 685, in <module> sys.exit(1) SystemExit: 1 with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:117) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:92) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) Results : Failed tests: test(org.apache.qpid.proton.JythonTest): Caught PyException on invocation number 2: Traceback (most recent call la (..) Tests run: 9, Failures: 1, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] proton-project .................................... SUCCESS [0.921s] [INFO] proton-j .......................................... SUCCESS [2.090s] [INFO] proton-jms ........................................ SUCCESS [0.140s] [INFO] proton-hawtdispatch ............................... SUCCESS [2.060s] [INFO] proton-tests ...................................... FAILURE [44.631s] [INFO] proton-j-messenger-example ........................ SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ > python test failed, but the overall build didnt > ----------------------------------------------- > > Key: PROTON-503 > URL: https://issues.apache.org/jira/browse/PROTON-503 > Project: Qpid Proton > Issue Type: Test > Environment: Windows 7 x64, running test inside the msysygit 'Git > Bash' shell. > Reporter: Robbie Gemmell > Priority: Critical > Fix For: 0.7 > > > When working on PROTON-501 and PROTON-502, I ran the tests (using mvn test). > I noticed one of the python tests fail as they ran (see snippets below), and > it was reported as failing when the python tests completed, but not when the > wrapping JUnit tests did, and as result the build itself was erroneously > marked a success. > Test Failure: > ========== > proton_tests.messenger.NBMessengerTest.testCreditReclaim ................ fail > Error during teardown: Traceback (most recent call last): > File "C:\workspace\proton\tests\python\proton-test", line 352, in run > phase() > File "C:\workspace\proton\tests\python\proton_tests\messenger.py", line > 710, in teardown > assert self.server.stopped > AssertionError > > Test results: > ========= > Totals: 266 tests, 219 passed, 21 skipped, 25 ignored, 1 failed > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.898 sec > Results : > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 > Build results: > ========== > [INFO] Reactor Summary: > [INFO] > [INFO] proton-project .................................... SUCCESS [1.029s] > [INFO] proton-j .......................................... SUCCESS [6.053s] > [INFO] proton-jms ........................................ SUCCESS [0.359s] > [INFO] proton-hawtdispatch ............................... SUCCESS [2.839s] > [INFO] proton-tests ...................................... SUCCESS [45.162s] > [INFO] proton-j-messenger-example ........................ SUCCESS [0.281s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ -- This message was sent by Atlassian JIRA (v6.1.5#6160)